Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Eric Nelson
Thanks Fabio. On 10/21/2016 06:43 AM, Fabio Estevam wrote: > Hi Eric, > > On Fri, Oct 21, 2016 at 11:39 AM, Eric Nelson wrote: > >> Reading the i.MX28 reference manual, it appears that this SoC doesn't >> have the RACC bit, and I missed removal of the FEC_QUIRK_HAS_RACC flag. > > On MX28 the r

Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Eric Nelson
Hi Henri, On 10/21/2016 06:39 AM, Eric Nelson wrote: > Hi Henri, > > On 10/21/2016 02:19 AM, Henri Roosen wrote: >> Hi, >> >> Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in >> hardware" breaks networking on an iMX28 system. >> >> The commit seems valid for iMX6, where it is teste

Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Fabio Estevam
Hi Eric, On Fri, Oct 21, 2016 at 11:39 AM, Eric Nelson wrote: > Reading the i.MX28 reference manual, it appears that this SoC doesn't > have the RACC bit, and I missed removal of the FEC_QUIRK_HAS_RACC flag. On MX28 the register is called HW_ENET_MAC_IPACCRXCONF. I sent a patch that fixes the

Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Eric Nelson
Hi Henri, On 10/21/2016 02:19 AM, Henri Roosen wrote: > Hi, > > Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in > hardware" breaks networking on an iMX28 system. > > The commit seems valid for iMX6, where it is tested okay and solves the > unaligned accesses. > > On iMX28 I stil

Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Henri Roosen
Hi Fabio, On 10/21/2016 12:55 PM, Fabio Estevam wrote: Hi Henri, 2016-10-21 7:19 GMT-02:00 Henri Roosen : Hi, Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in hardware" breaks networking on an iMX28 system. The commit seems valid for iMX6, where it is tested okay and solves th

Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Fabio Estevam
Hi Henri, 2016-10-21 7:19 GMT-02:00 Henri Roosen : > Hi, > > Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in > hardware" breaks networking on an iMX28 system. > > The commit seems valid for iMX6, where it is tested okay and solves the > unaligned accesses. > > On iMX28 I still see