Re: af_key: pfkey_dump needs parameter validation

2020-07-22 Thread Steffen Klassert
On Wed, Jul 22, 2020 at 03:20:59AM -0700, Mark Salyzyn wrote: > On 7/22/20 2:33 AM, Steffen Klassert wrote: > > On Tue, Jul 21, 2020 at 06:23:54AM -0700, Mark Salyzyn wrote: > > > In pfkey_dump() dplen and splen can both be specified to access the > > > xfrm_address_t structure out of bounds in__xf

Re: af_key: pfkey_dump needs parameter validation

2020-07-22 Thread Mark Salyzyn
On 7/22/20 2:33 AM, Steffen Klassert wrote: On Tue, Jul 21, 2020 at 06:23:54AM -0700, Mark Salyzyn wrote: In pfkey_dump() dplen and splen can both be specified to access the xfrm_address_t structure out of bounds in__xfrm_state_filter_match() when it calls addr_match() with the indexes. Return

Re: af_key: pfkey_dump needs parameter validation

2020-07-22 Thread Steffen Klassert
On Tue, Jul 21, 2020 at 06:23:54AM -0700, Mark Salyzyn wrote: > In pfkey_dump() dplen and splen can both be specified to access the > xfrm_address_t structure out of bounds in__xfrm_state_filter_match() > when it calls addr_match() with the indexes. Return EINVAL if either > are out of range. > >