Re: ZD1211RW unaligned accesses...

2007-12-01 Thread Ulrich Kunitz
John W. Linville wrote: > So, did the patch below fix the problem? Should I apply it? > > John John, the patch would have worked, but I have sent a second one to the list, which is based on Herbert's and has an assert to be able to test the patch on x86. You should be notify that the mac80211

Re: ZD1211RW unaligned accesses...

2007-11-30 Thread Johannes Berg
> Chances are it does make progress however we may still have the > general wireless/IP stack alignment issue that we are still discussing. Yeah, it's still on my list. I'll make a patch to WARN_ON unaligned data in a packet... although this is a bit complicated. ath5k actually had a bug with thi

Re: ZD1211RW unaligned accesses...

2007-11-30 Thread Herbert Xu
On Fri, Nov 30, 2007 at 06:34:56PM +1100, Shaddy Baddah wrote: > > OK... so I've applied patches left right and centre. As there have been > a few, I'll in-line them all at the bottom of this email. > > The result is that there are no more unaligned access messages at all. Good stuff! I was so

Re: ZD1211RW unaligned accesses...

2007-11-30 Thread Shaddy Baddah
Hi again, Herbert Xu wrote: On Thu, Nov 29, 2007 at 04:45:33PM -0500, John W. Linville wrote: So, did the patch below fix the problem? Should I apply it? I'm keen to find out the result too :) Chances are it does make progress however we may still have the general wireless/IP stack alignmen

Re: ZD1211RW unaligned accesses...

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 04:45:33PM -0500, John W. Linville wrote: > So, did the patch below fix the problem? Should I apply it? I'm keen to find out the result too :) Chances are it does make progress however we may still have the general wireless/IP stack alignment issue that we are still discu

Re: ZD1211RW unaligned accesses...

2007-11-29 Thread John W. Linville
So, did the patch below fix the problem? Should I apply it? John On Sat, Nov 24, 2007 at 11:02:16PM +0800, Herbert Xu wrote: > On Wed, Nov 21, 2007 at 01:00:44PM +, Shaddy Baddah wrote: > > > > It hasn't seemed to. I patched the source (confirming the patched lines > > are in), compiled, in

Re: ZD1211RW unaligned accesses...

2007-11-24 Thread Ulrich Kunitz
Herbert Xu wrote: > So please try the following patch (instead of the original one) > which should fix all the unailgned accesses in do_rx. > > Cheers, > -- > Visit Openswan at http://www.openswan.org/ > Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> > Home Page: http://gondor.apana.org.au/~he

Re: ZD1211RW unaligned accesses...

2007-11-24 Thread Herbert Xu
On Wed, Nov 21, 2007 at 01:00:44PM +, Shaddy Baddah wrote: > > It hasn't seemed to. I patched the source (confirming the patched lines > are in), compiled, installed and rebooted to effect the changes. My > zd1211rw modules timestamp indicates that I have an updated module: Thanks for your q

Re: ZD1211RW unaligned accesses...

2007-11-23 Thread Johannes Berg
> The problem is > drivers/net/wireless/zd1211/zd_mac.c:update_qual_rssi(). > Specifically the compare_ether_addr() call I don't believe this is true. Shaddy seems to back that up by the patch not helping. > Wireless folks, I would suggest we do some auditing of the > compare_ether_addr() calls a

Re: ZD1211RW unaligned accesses...

2007-11-21 Thread Shaddy Baddah
Hi David, David Miller wrote: Shaddy I attach a hack patch that you can use which should get rid of the warnings. It hasn't seemed to. I patched the source (confirming the patched lines are in), compiled, installed and rebooted to effect the changes. My zd1211rw modules timestamp indicates t