Re: Use of skb_unclone in drivers

2017-04-18 Thread James Hughes
On 18 April 2017 at 17:34, Florian Fainelli wrote: > On 04/18/2017 01:34 AM, James Hughes wrote: >> Thanks, > > (please don't top-post on netdev) > Trying not to! New to this. >> >> Quick check on that function - very similar to unclone which we know >> ameliorates the issue, just has the headro

Re: Use of skb_unclone in drivers

2017-04-18 Thread Florian Fainelli
On 04/18/2017 01:34 AM, James Hughes wrote: > Thanks, (please don't top-post on netdev) > > Quick check on that function - very similar to unclone which we know > ameliorates the issue, just has the headroom parameter rather than > priority. So clearly the right way to go. Just one more question

Re: Use of skb_unclone in drivers

2017-04-18 Thread James Hughes
Thanks, Quick check on that function - very similar to unclone which we know ameliorates the issue, just has the headroom parameter rather than priority. So clearly the right way to go. Just one more question I hope - where is the appropriate place for the skb_cow_head call in the driver - at the

Re: Use of skb_unclone in drivers

2017-04-17 Thread Eric Dumazet
On Mon, 2017-04-17 at 16:02 +0100, James Hughes wrote: > Netdevs, > > We have recently got to the bottom of an issue which we have been > encountering on a Raspberry Pi being used as an access point, and we > need a bit of advice on the correct way of fixing the issue. > > The set up is a Raspber