Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-12-05 Thread Craig Gallek
On Tue, Dec 5, 2017 at 3:07 PM, Eric Dumazet wrote: > On Tue, 2017-12-05 at 14:39 -0500, Craig Gallek wrote: >> On Tue, Dec 5, 2017 at 9:18 AM, Eric Dumazet >> wrote: >> > On Tue, 2017-12-05 at 06:15 -0800, Eric Dumazet wrote: >> > > >> > > + hlist_nulls_add_head_rcu(&sk->sk_nulss_node, list)

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-12-05 Thread Eric Dumazet
On Tue, 2017-12-05 at 14:39 -0500, Craig Gallek wrote: > On Tue, Dec 5, 2017 at 9:18 AM, Eric Dumazet > wrote: > > On Tue, 2017-12-05 at 06:15 -0800, Eric Dumazet wrote: > > > > > > + hlist_nulls_add_head_rcu(&sk->sk_nulss_node, list); > > > > Typo here, this needs sk_nulls_node of course. >

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-12-05 Thread Craig Gallek
On Tue, Dec 5, 2017 at 9:18 AM, Eric Dumazet wrote: > On Tue, 2017-12-05 at 06:15 -0800, Eric Dumazet wrote: >> >> + hlist_nulls_add_head_rcu(&sk->sk_nulss_node, list); > > Typo here, this needs sk_nulls_node of course. > Thanks Eric, this looks good to me. The tail insertion is still requir

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-12-05 Thread Eric Dumazet
On Tue, 2017-12-05 at 06:15 -0800, Eric Dumazet wrote: > > + hlist_nulls_add_head_rcu(&sk->sk_nulss_node, list); Typo here, this needs sk_nulls_node of course.

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-12-05 Thread Eric Dumazet
On Wed, 2017-11-22 at 07:58 -0800, Eric Dumazet wrote: > On Wed, Nov 22, 2017 at 5:38 AM, Alexander Potapenko om> wrote: > > On Thu, Oct 26, 2017 at 4:56 PM, Alexander Potapenko > .com> wrote: > > > On Thu, Oct 26, 2017 at 4:52 PM, Eric Dumazet > > m> wrote: > > > > On Thu, Oct 26, 2017 at 7:47

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-11-22 Thread Eric Dumazet
On Wed, Nov 22, 2017 at 5:38 AM, Alexander Potapenko wrote: > On Thu, Oct 26, 2017 at 4:56 PM, Alexander Potapenko > wrote: >> On Thu, Oct 26, 2017 at 4:52 PM, Eric Dumazet wrote: >>> On Thu, Oct 26, 2017 at 7:47 AM, Eric Dumazet wrote: On Thu, Oct 26, 2017 at 7:20 AM, Alexander Potapenko

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-11-22 Thread Alexander Potapenko
On Thu, Oct 26, 2017 at 4:56 PM, Alexander Potapenko wrote: > On Thu, Oct 26, 2017 at 4:52 PM, Eric Dumazet wrote: >> On Thu, Oct 26, 2017 at 7:47 AM, Eric Dumazet wrote: >>> On Thu, Oct 26, 2017 at 7:20 AM, Alexander Potapenko >>> wrote: On Thu, Oct 26, 2017 at 2:51 PM, Alexander Potapen

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-10-26 Thread Alexander Potapenko
On Thu, Oct 26, 2017 at 4:52 PM, Eric Dumazet wrote: > On Thu, Oct 26, 2017 at 7:47 AM, Eric Dumazet wrote: >> On Thu, Oct 26, 2017 at 7:20 AM, Alexander Potapenko >> wrote: >>> On Thu, Oct 26, 2017 at 2:51 PM, Alexander Potapenko >>> wrote: Hi David, Eric, I've changed KMSAN i

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-10-26 Thread Eric Dumazet
On Thu, Oct 26, 2017 at 7:47 AM, Eric Dumazet wrote: > On Thu, Oct 26, 2017 at 7:20 AM, Alexander Potapenko > wrote: >> On Thu, Oct 26, 2017 at 2:51 PM, Alexander Potapenko >> wrote: >>> Hi David, Eric, >>> >>> I've changed KMSAN instrumentation a bit and it's now reporting a new >>> error (se

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-10-26 Thread Eric Dumazet
On Thu, Oct 26, 2017 at 7:20 AM, Alexander Potapenko wrote: > On Thu, Oct 26, 2017 at 2:51 PM, Alexander Potapenko > wrote: >> Hi David, Eric, >> >> I've changed KMSAN instrumentation a bit and it's now reporting a new >> error (see below) when I SSH into a VM. > I've double-checked the old inst

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-10-26 Thread Alexander Potapenko
On Thu, Oct 26, 2017 at 2:51 PM, Alexander Potapenko wrote: > Hi David, Eric, > > I've changed KMSAN instrumentation a bit and it's now reporting a new > error (see below) when I SSH into a VM. I've double-checked the old instrumentation and found a bug in it, which led to masking some of the erro