Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-14 Thread Ard Biesheuvel
On Sat, 14 Nov 2020 at 01:40, Andrew Lunn wrote: > > > One question that still has not been answered is how many actual > > platforms were fixed by backporting Realtek's follow up fix to > > -stable. My suspicion is none. That by itself should be enough > > justification to revert the backport of

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Andrew Lunn
> One question that still has not been answered is how many actual > platforms were fixed by backporting Realtek's follow up fix to > -stable. My suspicion is none. That by itself should be enough > justification to revert the backport of that change. I think i've already said that would be a goo

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Ard Biesheuvel
On Fri, 13 Nov 2020 at 23:43, Andrew Lunn wrote: > > Hi Arnd > > > Something of that sort. I also see a similar patch in KSZ9031 > > now, see 7dd8f0ba88fc ("arm: dts: imx6qdl-udoo: fix rgmii phy-mode > > for ksz9031 phy") > > > > As this exact mismatch between rgmii and rgmii-id mode is apparently

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Andrew Lunn
Hi Arnd > Something of that sort. I also see a similar patch in KSZ9031 > now, see 7dd8f0ba88fc ("arm: dts: imx6qdl-udoo: fix rgmii phy-mode > for ksz9031 phy") > > As this exact mismatch between rgmii and rgmii-id mode is apparently > a more widespread problem, the best workaround I can think of

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Arnd Bergmann
On Fri, Nov 13, 2020 at 5:57 PM Andrew Lunn wrote: > > > > Hi Arnd > > > > > > This PHY driver bug hiding DT bug is always hard to handle. We have > > > been though it once before with the Atheros PHY. All the buggy DT > > > files were fixed in about one cycle. > > > > Do you have a link to the pr

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Andrew Lunn
> > Hi Arnd > > > > This PHY driver bug hiding DT bug is always hard to handle. We have > > been though it once before with the Atheros PHY. All the buggy DT > > files were fixed in about one cycle. > > Do you have a link to the problem for the Atheros PHY? commit cd28d1d6e52e740130745429b3ff0af7

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Arnd Bergmann
On Fri, Nov 13, 2020 at 3:45 PM Andrew Lunn wrote: > > > > Sadly, there is one board - Pine64 Plus - where HW settings are wrong and > > > it > > > actually needs SW override. Until this Realtek PHY driver fix was merged, > > > it > > > was unclear what magic value provided by Realtek to board m

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Andrew Lunn
> > Sadly, there is one board - Pine64 Plus - where HW settings are wrong and it > > actually needs SW override. Until this Realtek PHY driver fix was merged, it > > was unclear what magic value provided by Realtek to board manufacturer does. > > > > Reference: > > https://lore.kernel.org/netdev/20

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Arnd Bergmann
On Thu, Nov 5, 2020 at 6:28 PM Jernej Škrabec wrote: > Dne četrtek, 29. oktober 2020 ob 15:46:44 CET je Ilias Apalodimas napisal(a): > > On Thu, Oct 29, 2020 at 03:39:34PM +0100, Andrew Lunn wrote: > > > > What about reverting the realtek PHY commit from stable? > > > > As Ard said it doesn't real

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-05 Thread Jernej Škrabec
Hi! Dne četrtek, 29. oktober 2020 ob 15:46:44 CET je Ilias Apalodimas napisal(a): > On Thu, Oct 29, 2020 at 03:39:34PM +0100, Andrew Lunn wrote: > > > What about reverting the realtek PHY commit from stable? > > > As Ard said it doesn't really fix anything (usage wise) and causes a bunch of > > >