Re: RTL8402 stops working after hibernate/resume

On 30.09.2020 23:44, Petr Tesarik wrote: > On Wed, 30 Sep 2020 22:11:02 +0200 > Heiner Kallweit wrote: > >> On 30.09.2020 20:00, Petr Tesarik wrote: >> [...] >>> WoL still does not work on my laptop, but this might be an unrelated >>> issue, and I can even imagine the BIOS is buggy in this regard

Re: RTL8402 stops working after hibernate/resume

On Wed, 30 Sep 2020 22:11:02 +0200 Heiner Kallweit wrote: > On 30.09.2020 20:00, Petr Tesarik wrote: >[...] > > WoL still does not work on my laptop, but this might be an unrelated > > issue, and I can even imagine the BIOS is buggy in this regard. > > > A simple further check you could do: >

Re: RTL8402 stops working after hibernate/resume

On 30.09.2020 20:00, Petr Tesarik wrote: > Hi Heiner again, > > On Wed, 30 Sep 2020 19:32:59 +0200 > Petr Tesarik wrote: > >> Hi Heiner, >> >> On Wed, 30 Sep 2020 18:41:24 +0200 >> Petr Tesarik wrote: >> >>> HI Heiner, >>> >>> On Wed, 30 Sep 2020 17:47:15 +0200 >>> Heiner Kallweit wrote: >>> [

Re: RTL8402 stops working after hibernate/resume

On Wed, 30 Sep 2020 17:47:15 +0200 Heiner Kallweit wrote: >[...] > Petr, > in the following I send two patches. First one is supposed to fix the freeze. > It also fixes another issue that existed before my ether_clk change: > ether_clk was disabled on suspend even if WoL is enabled. And the netwo

Re: RTL8402 stops working after hibernate/resume

Hi Heiner again, On Wed, 30 Sep 2020 19:32:59 +0200 Petr Tesarik wrote: > Hi Heiner, > > On Wed, 30 Sep 2020 18:41:24 +0200 > Petr Tesarik wrote: > > > HI Heiner, > > > > On Wed, 30 Sep 2020 17:47:15 +0200 > > Heiner Kallweit wrote: > >[...] > > > Petr, > > > in the following I send two p

Re: RTL8402 stops working after hibernate/resume

Hi Heiner, On Wed, 30 Sep 2020 18:41:24 +0200 Petr Tesarik wrote: > HI Heiner, > > On Wed, 30 Sep 2020 17:47:15 +0200 > Heiner Kallweit wrote: >[...] > > Petr, > > in the following I send two patches. First one is supposed to fix the > > freeze. > > It also fixes another issue that existed be

Re: RTL8402 stops working after hibernate/resume

On 30.09.2020 18:41, Petr Tesarik wrote: > HI Heiner, > > On Wed, 30 Sep 2020 17:47:15 +0200 > Heiner Kallweit wrote: > >> On 30.09.2020 11:04, Hans de Goede wrote: >>> Hi, >>> >>> On 9/29/20 10:35 PM, Heiner Kallweit wrote: On 29.09.2020 22:08, Hans de Goede wrote: >>> >>> >>>

Re: RTL8402 stops working after hibernate/resume

HI Heiner, On Wed, 30 Sep 2020 17:47:15 +0200 Heiner Kallweit wrote: > On 30.09.2020 11:04, Hans de Goede wrote: > > Hi, > > > > On 9/29/20 10:35 PM, Heiner Kallweit wrote: > >> On 29.09.2020 22:08, Hans de Goede wrote: > > > > > > > >>> Also some remarks about this while I'm being a b

Re: RTL8402 stops working after hibernate/resume

On 30.09.2020 11:04, Hans de Goede wrote: > Hi, > > On 9/29/20 10:35 PM, Heiner Kallweit wrote: >> On 29.09.2020 22:08, Hans de Goede wrote: > > > >>> Also some remarks about this while I'm being a bit grumpy about >>> all this anyways (sorry): >>> >>> 1. 9f0b54cd167219 ("r8169: move switching

Re: RTL8402 stops working after hibernate/resume

Hi, On 9/29/20 10:35 PM, Heiner Kallweit wrote: On 29.09.2020 22:08, Hans de Goede wrote: Also some remarks about this while I'm being a bit grumpy about all this anyways (sorry): 1. 9f0b54cd167219 ("r8169: move switching optional clock on/off to pll power functions") commit's message does

Re: RTL8402 stops working after hibernate/resume

Hi, On Tue, 29 Sep 2020 22:08:56 +0200 Hans de Goede wrote: > Hi, > > On 9/29/20 9:07 PM, Petr Tesarik wrote: > > Hi Heiner (and now also Hans)! > > > > @Hans: I'm adding you to this conversation, because you're the author > > of commit b1e3454d39f99, which seems to break the r8169 driver on a

Re: RTL8402 stops working after hibernate/resume

On 29.09.2020 22:35, Heiner Kallweit wrote: > On 29.09.2020 22:08, Hans de Goede wrote: >> Hi, >> >> On 9/29/20 9:07 PM, Petr Tesarik wrote: >>> Hi Heiner (and now also Hans)! >>> >>> @Hans: I'm adding you to this conversation, because you're the author >>> of commit b1e3454d39f99, which seems to b

Re: RTL8402 stops working after hibernate/resume

On 29.09.2020 22:08, Hans de Goede wrote: > Hi, > > On 9/29/20 9:07 PM, Petr Tesarik wrote: >> Hi Heiner (and now also Hans)! >> >> @Hans: I'm adding you to this conversation, because you're the author >> of commit b1e3454d39f99, which seems to break the r8169 driver on a >> laptop of mine. > > E

Re: RTL8402 stops working after hibernate/resume

p.s. On 9/29/20 10:08 PM, Hans de Goede wrote: So I believe that the proper fix for this is to revert commit 9f0b54cd167219 ("r8169: move switching optional clock on/off to pll power functions") Heiner, assuming you agree that reverting this commit is the best way to fix this, can you pleas

Re: RTL8402 stops working after hibernate/resume

Hi, On 9/29/20 9:07 PM, Petr Tesarik wrote: Hi Heiner (and now also Hans)! @Hans: I'm adding you to this conversation, because you're the author of commit b1e3454d39f99, which seems to break the r8169 driver on a laptop of mine. Erm, no, as you bi-sected yourself already commit 9f0b54cd167219

Re: RTL8402 stops working after hibernate/resume

On 29.09.2020 21:07, Petr Tesarik wrote: > Hi Heiner (and now also Hans)! > > @Hans: I'm adding you to this conversation, because you're the author > of commit b1e3454d39f99, which seems to break the r8169 driver on a > laptop of mine. > > On Fri, 25 Sep 2020 16:47:54 +0200 > Heiner Kallweit wro

Re: RTL8402 stops working after hibernate/resume

Hi Heiner (and now also Hans)! @Hans: I'm adding you to this conversation, because you're the author of commit b1e3454d39f99, which seems to break the r8169 driver on a laptop of mine. On Fri, 25 Sep 2020 16:47:54 +0200 Heiner Kallweit wrote: > On 25.09.2020 14:56, Petr Tesarik wrote: > > On Fr

Re: RTL8402 stops working after hibernate/resume

On 25.09.2020 14:56, Petr Tesarik wrote: > On Fri, 25 Sep 2020 11:52:41 +0200 > Petr Tesarik wrote: > >> On Fri, 25 Sep 2020 11:44:09 +0200 >> Heiner Kallweit wrote: >> >>> On 25.09.2020 10:54, Petr Tesarik wrote: >> [...] Does it make sense to bisect the change that broke the driver for

Re: RTL8402 stops working after hibernate/resume

On Fri, 25 Sep 2020 11:52:41 +0200 Petr Tesarik wrote: > On Fri, 25 Sep 2020 11:44:09 +0200 > Heiner Kallweit wrote: > > > On 25.09.2020 10:54, Petr Tesarik wrote: >[...] > > > Does it make sense to bisect the change that broke the driver for me, or > > > should I rather dispose of this wast

Re: RTL8402 stops working after hibernate/resume

On Fri, 25 Sep 2020 11:44:09 +0200 Heiner Kallweit wrote: > On 25.09.2020 10:54, Petr Tesarik wrote: > > On Fri, 25 Sep 2020 09:30:37 +0200 > > Petr Tesarik wrote: > > > >> On Thu, 24 Sep 2020 22:12:24 +0200 > >> Heiner Kallweit wrote: > >> > >>> On 24.09.2020 21:14, Petr Tesarik wrote:

Re: RTL8402 stops working after hibernate/resume

On 25.09.2020 10:54, Petr Tesarik wrote: > On Fri, 25 Sep 2020 09:30:37 +0200 > Petr Tesarik wrote: > >> On Thu, 24 Sep 2020 22:12:24 +0200 >> Heiner Kallweit wrote: >> >>> On 24.09.2020 21:14, Petr Tesarik wrote: On Wed, 23 Sep 2020 11:57:41 +0200 Heiner Kallweit wrote: >>>

Re: RTL8402 stops working after hibernate/resume

On Fri, 25 Sep 2020 09:30:37 +0200 Petr Tesarik wrote: > On Thu, 24 Sep 2020 22:12:24 +0200 > Heiner Kallweit wrote: > > > On 24.09.2020 21:14, Petr Tesarik wrote: > > > On Wed, 23 Sep 2020 11:57:41 +0200 > > > Heiner Kallweit wrote: > > > > > >> On 03.09.2020 10:41, Petr Tesarik wrote:

Re: RTL8402 stops working after hibernate/resume

On Thu, 24 Sep 2020 22:12:24 +0200 Heiner Kallweit wrote: > On 24.09.2020 21:14, Petr Tesarik wrote: > > On Wed, 23 Sep 2020 11:57:41 +0200 > > Heiner Kallweit wrote: > > > >> On 03.09.2020 10:41, Petr Tesarik wrote: > >>> Hi Heiner, > >>> > >>> this issue was on the back-burner for some time,

Re: RTL8402 stops working after hibernate/resume

On 24.09.2020 21:14, Petr Tesarik wrote: > On Wed, 23 Sep 2020 11:57:41 +0200 > Heiner Kallweit wrote: > >> On 03.09.2020 10:41, Petr Tesarik wrote: >>> Hi Heiner, >>> >>> this issue was on the back-burner for some time, but I've got some >>> interesting news now. >>> >>> On Sat, 18 Jul 2020 14:0

Re: RTL8402 stops working after hibernate/resume

On 24.09.2020 21:14, Petr Tesarik wrote: > On Wed, 23 Sep 2020 11:57:41 +0200 > Heiner Kallweit wrote: > >> On 03.09.2020 10:41, Petr Tesarik wrote: >>> Hi Heiner, >>> >>> this issue was on the back-burner for some time, but I've got some >>> interesting news now. >>> >>> On Sat, 18 Jul 2020 14:0

Re: RTL8402 stops working after hibernate/resume

On Wed, 23 Sep 2020 11:57:41 +0200 Heiner Kallweit wrote: > On 03.09.2020 10:41, Petr Tesarik wrote: > > Hi Heiner, > > > > this issue was on the back-burner for some time, but I've got some > > interesting news now. > > > > On Sat, 18 Jul 2020 14:07:50 +0200 > > Heiner Kallweit wrote: > >

Re: RTL8402 stops working after hibernate/resume

On 03.09.2020 10:41, Petr Tesarik wrote: > Hi Heiner, > > this issue was on the back-burner for some time, but I've got some > interesting news now. > > On Sat, 18 Jul 2020 14:07:50 +0200 > Heiner Kallweit wrote: > >> [...] >> Maybe the following gives us an idea: >> Please do "ethtool -d " aft

Re: RTL8402 stops working after hibernate/resume

Hi Heiner, any comment on my findings? On Thu, 3 Sep 2020 10:41:22 +0200 Petr Tesarik wrote: > Hi Heiner, > > this issue was on the back-burner for some time, but I've got some > interesting news now. > > On Sat, 18 Jul 2020 14:07:50 +0200 > Heiner Kallweit wrote: > > >[...] > > Maybe the f

Re: RTL8402 stops working after hibernate/resume

Hi Heiner, this issue was on the back-burner for some time, but I've got some interesting news now. On Sat, 18 Jul 2020 14:07:50 +0200 Heiner Kallweit wrote: >[...] > Maybe the following gives us an idea: > Please do "ethtool -d " after boot and after resume from suspend, > and check for differ

Re: RTL8402 stops working after hibernate/resume

On 16.07.2020 10:58, Petr Tesarik wrote: > Hi Heiner, > > first, thank you for looking into this! > > On Wed, 15 Jul 2020 17:22:35 +0200 > Heiner Kallweit wrote: > >> On 15.07.2020 10:28, Petr Tesarik wrote: >>> Hi all, >>> >>> I've encountered some issues on an Asus laptop. The RTL8402 receive

Re: RTL8402 stops working after hibernate/resume

Hi Heiner, first, thank you for looking into this! On Wed, 15 Jul 2020 17:22:35 +0200 Heiner Kallweit wrote: > On 15.07.2020 10:28, Petr Tesarik wrote: > > Hi all, > > > > I've encountered some issues on an Asus laptop. The RTL8402 receive > > queue behaves strangely after suspend to RAM and r

Re: RTL8402 stops working after hibernate/resume

On 15.07.2020 10:28, Petr Tesarik wrote: > Hi all, > > I've encountered some issues on an Asus laptop. The RTL8402 receive > queue behaves strangely after suspend to RAM and resume - many incoming > packets are truncated, but not all and not always to the same length > (most commonly 60 bytes, but

Re: RTL8402 stops working after hibernate/resume

On 15.07.2020 10:28, Petr Tesarik wrote: > Hi all, > > I've encountered some issues on an Asus laptop. The RTL8402 receive > queue behaves strangely after suspend to RAM and resume - many incoming > packets are truncated, but not all and not always to the same length > (most commonly 60 bytes, but