From: Michael Buesch <[EMAIL PROTECTED]>
Date: Thu, 10 May 2007 13:23:40 +0200
> Nah, Jeff. Please don't go this path.
> If we have to remove all magic numbers from drivers, we'd have to either
> *) Drop reverse engineered drivers like bcm43xx completely.
> *) Clutter them with completely useless
On Thursday 10 May 2007 04:16:22 Michael Wu wrote:
> > > + rtl818x_iowrite8(priv, (u8 *)0xFE18, 0x10);
> > > + rtl818x_iowrite8(priv, (u8 *)0xFE18, 0x11);
> > > + rtl818x_iowrite8(priv, (u8 *)0xFE18, 0x00);
> > > + mdelay(200);
> >
> > ditto
> >
> > also, kill the magic numbers
> >
> I have no idea
On Thursday 10 May 2007 00:21, Jeff Garzik wrote:
> Michael Wu wrote:
> > On Wednesday 09 May 2007 19:12, Jeff Garzik wrote:
> >> John W. Linville wrote:
> >>> +static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6
> >>> *eeprom) +{
> >>> + eeprom->reg_data_clock = 1;
> >>> + eeprom->regis
Michael Wu wrote:
On Wednesday 09 May 2007 19:12, Jeff Garzik wrote:
John W. Linville wrote:
+static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
+{
+ eeprom->reg_data_clock = 1;
+ eeprom->register_write(eeprom);
+ udelay(1);
+}
+
+static inline void eeprom
On Wednesday 09 May 2007 19:12, Jeff Garzik wrote:
> John W. Linville wrote:
> > +static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
> > +{
> > + eeprom->reg_data_clock = 1;
> > + eeprom->register_write(eeprom);
> > + udelay(1);
> > +}
> > +
> > +static inline void eeprom
John W. Linville wrote:
+static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
+{
+ eeprom->reg_data_clock = 1;
+ eeprom->register_write(eeprom);
+ udelay(1);
+}
+
+static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
+{
+ eeprom->reg_da
