Re: Generic TSO

2016-03-14 Thread Alexander Duyck
On Mon, Mar 14, 2016 at 3:32 AM, Edward Cree wrote: > On 14/03/16 10:26, Edward Cree wrote: >> On 12/03/16 05:40, Alexander Duyck wrote: >>> Well that is the thing. Before we can actually start tinkering with >>> the outer header we probably need to make sure we set the DF bit and >>> that it wou

Re: Generic TSO

2016-03-14 Thread Edward Cree
On 14/03/16 10:26, Edward Cree wrote: > On 12/03/16 05:40, Alexander Duyck wrote: >> Well that is the thing. Before we can actually start tinkering with >> the outer header we probably need to make sure we set the DF bit and >> that it would be honored on the outer headers for IPv4. I don't >> be

Re: Generic TSO

2016-03-14 Thread Edward Cree
On 12/03/16 05:40, Alexander Duyck wrote: > Well that is the thing. Before we can actually start tinkering with > the outer header we probably need to make sure we set the DF bit and > that it would be honored on the outer headers for IPv4. I don't > believe any of the tunnels are currently doing

Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)

2016-03-11 Thread Alexander Duyck
On Fri, Mar 11, 2016 at 2:55 PM, Tom Herbert wrote: > On Fri, Mar 11, 2016 at 2:31 PM, Alexander Duyck > wrote: >> On Fri, Mar 11, 2016 at 1:29 PM, Edward Cree wrote: >>> On 11/03/16 21:09, Alexander Duyck wrote: The only real issue with the "generic" TSO is that it isn't going to be s

Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)

2016-03-11 Thread Tom Herbert
On Fri, Mar 11, 2016 at 2:31 PM, Alexander Duyck wrote: > On Fri, Mar 11, 2016 at 1:29 PM, Edward Cree wrote: >> On 11/03/16 21:09, Alexander Duyck wrote: >>> The only real issue with the "generic" TSO is that it isn't going to >>> be so generic. We have different devices that will support diffe

Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)

2016-03-11 Thread Alexander Duyck
On Fri, Mar 11, 2016 at 1:29 PM, Edward Cree wrote: > On 11/03/16 21:09, Alexander Duyck wrote: >> The only real issue with the "generic" TSO is that it isn't going to >> be so generic. We have different devices that will support different >> levels of stuff. For example the ixgbe drivers will n

Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)

2016-03-11 Thread Edward Cree
On 11/03/16 21:09, Alexander Duyck wrote: > The only real issue with the "generic" TSO is that it isn't going to > be so generic. We have different devices that will support different > levels of stuff. For example the ixgbe drivers will need to treat the > outer tunnel header as one giant L2 hea

Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)

2016-03-11 Thread Alexander Duyck
On Fri, Mar 11, 2016 at 12:24 PM, Edward Cree wrote: > On 11/03/16 20:16, Tom Herbert wrote: >> On Fri, Mar 11, 2016 at 11:59 AM, Edward Cree wrote: >>> On 11/03/16 19:57, Tom Herbert wrote: On Fri, Mar 11, 2016 at 11:20 AM, Edward Cree wrote: > Tom, > > Are you planning to / wo

Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)

2016-03-11 Thread Edward Cree
On 11/03/16 20:16, Tom Herbert wrote: > On Fri, Mar 11, 2016 at 11:59 AM, Edward Cree wrote: >> On 11/03/16 19:57, Tom Herbert wrote: >>> On Fri, Mar 11, 2016 at 11:20 AM, Edward Cree wrote: Tom, Are you planning to / working on implementing this? If not, I might have a crack

Re: Generic TSO

2016-03-11 Thread David Miller
From: Edward Cree Date: Fri, 11 Mar 2016 19:20:41 + > Are you planning to / working on implementing this? If not, I might have a > crack at it; I've talked to our firmware guys and (provisionally) we think > we can support it in current sfc hardware. > Or were there any blocking problems rai

Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)

2016-03-11 Thread Tom Herbert
On Fri, Mar 11, 2016 at 11:59 AM, Edward Cree wrote: > On 11/03/16 19:57, Tom Herbert wrote: >> On Fri, Mar 11, 2016 at 11:20 AM, Edward Cree wrote: >>> Tom, >>> >>> Are you planning to / working on implementing this? If not, I might have a >>> crack at it; I've talked to our firmware guys and (

Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)

2016-03-11 Thread Edward Cree
On 11/03/16 19:57, Tom Herbert wrote: > On Fri, Mar 11, 2016 at 11:20 AM, Edward Cree wrote: >> Tom, >> >> Are you planning to / working on implementing this? If not, I might have a >> crack at it; I've talked to our firmware guys and (provisionally) we think >> we can support it in current sfc h

Re: Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default)

2016-03-11 Thread Tom Herbert
On Fri, Mar 11, 2016 at 11:20 AM, Edward Cree wrote: > On 20/02/16 19:51, Tom Herbert wrote: >> Right. To use LCO with TSO we would need to ensure that all packets >> are the same size so that the UDP length field and thus checksum are >> constant for all created segments. But this property this w