Re: EoGRE sends undersized frames without padding

2019-06-07 Thread Gregory Rose
On 6/7/2019 12:57 PM, Cong Wang wrote: On Thu, Jun 6, 2019 at 12:36 AM Steinar H. Gunderson wrote: On Wed, Jun 05, 2019 at 06:17:51PM -0700, Cong Wang wrote: Hmm, sounds like openvswitch should pad the packets in this scenario, like hardware switches padding those on real wires. Well, openv

Re: EoGRE sends undersized frames without padding

2019-06-07 Thread Steinar H. Gunderson
On Fri, Jun 07, 2019 at 12:57:57PM -0700, Cong Wang wrote: >> Well, openvswitch say that they just throw packets around and assume they're >> valid... :-) > _If_ the hardware switch has to pad them (according to what you said), > why software switch doesn't? Trust me, I'm telling them they have to

Re: EoGRE sends undersized frames without padding

2019-06-07 Thread Cong Wang
On Thu, Jun 6, 2019 at 12:36 AM Steinar H. Gunderson wrote: > > On Wed, Jun 05, 2019 at 06:17:51PM -0700, Cong Wang wrote: > > Hmm, sounds like openvswitch should pad the packets in this scenario, > > like hardware switches padding those on real wires. > > Well, openvswitch say that they just thro

Re: EoGRE sends undersized frames without padding

2019-06-06 Thread Steinar H. Gunderson
On Wed, Jun 05, 2019 at 06:17:51PM -0700, Cong Wang wrote: > Hmm, sounds like openvswitch should pad the packets in this scenario, > like hardware switches padding those on real wires. Well, openvswitch say that they just throw packets around and assume they're valid... :-) In any case, if you ta

Re: EoGRE sends undersized frames without padding

2019-06-05 Thread Cong Wang
On Wed, Jun 5, 2019 at 12:27 AM Steinar H. Gunderson wrote: > > On Tue, Jun 04, 2019 at 09:31:42PM -0700, Cong Wang wrote: > >> This works fine for large packets, but the system in the other end > >> drops smaller packets, such as ARP requests and small ICMP pings. > > Is the other end Linux too?

Re: EoGRE sends undersized frames without padding

2019-06-05 Thread Steinar H. Gunderson
On Tue, Jun 04, 2019 at 09:31:42PM -0700, Cong Wang wrote: >> This works fine for large packets, but the system in the other end >> drops smaller packets, such as ARP requests and small ICMP pings. > Is the other end Linux too? Yes and no. The other end is Linux with Open vSwitch, which sends the

Re: EoGRE sends undersized frames without padding

2019-06-04 Thread Cong Wang
On Thu, May 30, 2019 at 2:08 AM Steinar H. Gunderson wrote: > > Hi, > > I'm trying to connect some VMs over EoGRE (using gretap on my side): > > ip link add foo type gretap remote local > > This works fine for large packets, but the system in the other end > drops smaller packets, such as ARP

Re: EoGRE sends undersized frames without padding

2019-06-04 Thread Steinar H. Gunderson
On Fri, May 31, 2019 at 12:38:32AM +0200, Steinar H. Gunderson wrote: > As a proof of concept (no error handling, probably poor performance, not > implemented for IPv6, other issues?), this patch works and fixes my problem: Hi, Any comments on this? /* Steinar */ -- Homepage: https://www.sesse.

Re: EoGRE sends undersized frames without padding

2019-05-30 Thread Steinar H. Gunderson
On Thu, May 30, 2019 at 10:35:08AM +0200, Steinar H. Gunderson wrote: > After looking at the GRE packets in Wireshark, it turns out the Ethernet > packets within the EoGRE packet is undersized (under 60 bytes), and Linux > doesn't pad them. I haven't found anything in RFC 7637 that says anything >