Re: BUGs in skb_checksum_help() and skb_gso_segment() in 2.6.18-rc2

2006-07-25 Thread Herbert Xu
On Wed, Jul 26, 2006 at 06:01:40AM +0200, Patrick McHardy wrote: > > Please send it, I'll update my patch based on that. Thanks. Here it is, it sits on top of commit ca6bb5d7ab22ac79f608fe6cbc6b12de6a5a19f0 Author: David Woodhouse <[EMAIL PROTECTED]> Date: Thu Jun 22 16:07:52 2006 -0700 [

Re: BUGs in skb_checksum_help() and skb_gso_segment() in 2.6.18-rc2

2006-07-25 Thread Patrick McHardy
Herbert Xu wrote: > Hi Patrick: > > On Wed, Jul 26, 2006 at 05:38:07AM +0200, Patrick McHardy wrote: > >>I have a patch which changes netfilter to do incremental checksumming. >>The hook number is passed to all functions doing this so they know >>how to update the checksum. Could you explain how

Re: BUGs in skb_checksum_help() and skb_gso_segment() in 2.6.18-rc2

2006-07-25 Thread Herbert Xu
Hi Patrick: On Wed, Jul 26, 2006 at 05:38:07AM +0200, Patrick McHardy wrote: > > I have a patch which changes netfilter to do incremental checksumming. > The hook number is passed to all functions doing this so they know > how to update the checksum. Could you explain how > CHECKSUM_COMPLETE/CHEC

Re: BUGs in skb_checksum_help() and skb_gso_segment() in 2.6.18-rc2

2006-07-25 Thread Patrick McHardy
Herbert Xu wrote: > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > >>It is not a bug, but remind to update nat helper function. > > > Yes, I need to add CHECKSUM_COMPLETE vs. CHECKSUM_PARTIAL first so that > we actually know which is which in NAT. I have a patch which changes netfilter to do in

Re: BUGs in skb_checksum_help() and skb_gso_segment() in 2.6.18-rc2

2006-07-25 Thread Herbert Xu
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > On Tue, Jul 25, 2006 at 05:15:04PM +0200, Tomasz Torcz ([EMAIL PROTECTED]) > wrote: >> BUG: warning at net/core/dev.c:1171/skb_checksum_help() >> [] show_trace_log_lvl+0x51/0xe6 >> [] show_trace+0xa/0xc >> [] dump_stack+0x13/0x15 >> [] skb_checksum

Re: BUGs in skb_checksum_help() and skb_gso_segment() in 2.6.18-rc2

2006-07-25 Thread Evgeniy Polyakov
On Tue, Jul 25, 2006 at 05:15:04PM +0200, Tomasz Torcz ([EMAIL PROTECTED]) wrote: > BUG: warning at net/core/dev.c:1171/skb_checksum_help() > [] show_trace_log_lvl+0x51/0xe6 > [] show_trace+0xa/0xc > [] dump_stack+0x13/0x15 > [] skb_checksum_help+0x4d/0xeb > [] ip_nat_fn+0x47/0x19a It is not