Re: 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp

2006-09-18 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 15 Sep 2006 22:16:17 +0200 > bert hubert wrote: > >>It appears to be intentionally, but I don't see a reason for it. > >>Can you try if this patch makes it work as expected? > > > > > >>[PACKET]: Don't truncate non-linear skbs with mmaped IO >

Re: 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp

2006-09-15 Thread Patrick McHardy
bert hubert wrote: >>It appears to be intentionally, but I don't see a reason for it. >>Can you try if this patch makes it work as expected? > > >>[PACKET]: Don't truncate non-linear skbs with mmaped IO >> >>Non-linear skbs are truncated to their linear part with mmaped IO. >>Fix by using skb_cop

Re: 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp

2006-09-15 Thread bert hubert
> It appears to be intentionally, but I don't see a reason for it. > Can you try if this patch makes it work as expected? > [PACKET]: Don't truncate non-linear skbs with mmaped IO > > Non-linear skbs are truncated to their linear part with mmaped IO. > Fix by using skb_copy_bits instead of memcpy

Re: 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp

2006-09-14 Thread Alexey Kuznetsov
Hello! > [PACKET]: Don't truncate non-linear skbs with mmaped IO > > Non-linear skbs are truncated to their linear part with mmaped IO. > Fix by using skb_copy_bits instead of memcpy. Ack. I remember this trick. The "idea" was that I needed only TCP header in any case and it was perfect cutoff.

Re: 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp

2006-09-14 Thread Patrick McHardy
bert hubert wrote: > On Wed, Sep 13, 2006 at 08:44:21PM +0200, Patrick McHardy wrote: > > >>Are you using TSO on the outgoing device? If so please try to log the >>packet using iptables to see if it really is a TSO packet. > > > Good catch! I turned off TSO and things are working fine again. >

Re: 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp

2006-09-14 Thread bert hubert
On Wed, Sep 13, 2006 at 08:44:21PM +0200, Patrick McHardy wrote: > Are you using TSO on the outgoing device? If so please try to log the > packet using iptables to see if it really is a TSO packet. Good catch! I turned off TSO and things are working fine again. Is this a known problem, should it

Re: 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp

2006-09-13 Thread Patrick McHardy
bert hubert wrote: > Hi people, > > I like to use memory mapped pcap (PACKET_MMAP) since off the shelf, linux is > a tad prone to drop packets while capturing these days. It used to be lots > better at it, but right now memory mapped pcap is the only way to get things > working a bit. I've noticed