Re: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static

2006-03-23 Thread Adrian Bunk
On Thu, Mar 23, 2006 at 09:37:15PM -0500, Jing Min Zhao wrote: > > I'd like to keep it global. In the future we may need it. The point is: There have been many occasions where people have said "I will need this soon" in many different places in the kernel, and one year later it was still unused

Re: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static

2006-03-23 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Fri, 24 Mar 2006 08:55:11 +0100 > The point is: > There have been many occasions where people have said "I will need this > soon" in many different places in the kernel, and one year later it was > still unused. > > If it will be needed at some point

Re: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static

2006-03-23 Thread Jing Min Zhao
- Original Message - From: "Adrian Bunk" <[EMAIL PROTECTED]> To: "Jing Min Zhao" <[EMAIL PROTECTED]> Cc: ; <[EMAIL PROTECTED]>; Sent: Thursday, March 23, 2006 7:09 PM Subject: [RFC: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static I'd like to keep it global. In th