Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-06 Thread Jiri Pirko
Tue, Aug 06, 2019 at 07:55:30PM CEST, dsah...@gmail.com wrote: >On 8/6/19 11:53 AM, Jiri Pirko wrote: >> Let's figure out the devlink-controlling-kernel-resources thread first. >> What you describe here is exactly that. > >as I mentioned on the phone, any outcome of that thread will be in 5.4 >at b

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-06 Thread David Ahern
On 8/6/19 11:53 AM, Jiri Pirko wrote: > Let's figure out the devlink-controlling-kernel-resources thread first. > What you describe here is exactly that. as I mentioned on the phone, any outcome of that thread will be in 5.4 at best. Meanwhile this breakage in 5.2 and 5.3 needs to be fixed.

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-06 Thread Jiri Pirko
Tue, Aug 06, 2019 at 07:34:59PM CEST, dsah...@gmail.com wrote: >On 8/5/19 9:20 AM, Jiri Pirko wrote: >> Mon, Aug 05, 2019 at 04:51:22PM CEST, dsah...@gmail.com wrote: >>> On 8/5/19 8:49 AM, Jiri Pirko wrote: > Your commit 5fc494225c1eb81309cc4c91f183cd30e4edb674 changed that from a > per-na

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-06 Thread David Ahern
On 8/5/19 9:20 AM, Jiri Pirko wrote: > Mon, Aug 05, 2019 at 04:51:22PM CEST, dsah...@gmail.com wrote: >> On 8/5/19 8:49 AM, Jiri Pirko wrote: Your commit 5fc494225c1eb81309cc4c91f183cd30e4edb674 changed that from a per-namepace accounting to all namespaces managed by a single devlink

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-05 Thread Jiri Pirko
Mon, Aug 05, 2019 at 04:51:22PM CEST, dsah...@gmail.com wrote: >On 8/5/19 8:49 AM, Jiri Pirko wrote: >>> Your commit 5fc494225c1eb81309cc4c91f183cd30e4edb674 changed that from a >>> per-namepace accounting to all namespaces managed by a single devlink >>> instance in init_net - which is completely

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-05 Thread David Ahern
On 8/5/19 8:49 AM, Jiri Pirko wrote: >> Your commit 5fc494225c1eb81309cc4c91f183cd30e4edb674 changed that from a >> per-namepace accounting to all namespaces managed by a single devlink >> instance in init_net - which is completely wrong. > No. Not "all namespaces". Only the one where the devlink i

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-05 Thread Jiri Pirko
Mon, Aug 05, 2019 at 04:10:39PM CEST, dsah...@gmail.com wrote: >On 8/4/19 11:54 PM, Jiri Pirko wrote: >> There was implicit devlink instance creation per-namespace. No relation >> any actual device. It was wrong and misuse of devlink. >> >> Now you have 1 devlink instance per 1 device as it should

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-05 Thread David Ahern
On 8/4/19 11:54 PM, Jiri Pirko wrote: > There was implicit devlink instance creation per-namespace. No relation > any actual device. It was wrong and misuse of devlink. > > Now you have 1 devlink instance per 1 device as it should be. Also, you > have fib resource control for this device, also as

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-04 Thread Jiri Pirko
Fri, Aug 02, 2019 at 05:45:36PM CEST, dsah...@gmail.com wrote: >On 8/2/19 1:48 AM, Jiri Pirko wrote: >> Wed, Jul 31, 2019 at 09:58:10PM CEST, dsah...@gmail.com wrote: >>> On 7/31/19 1:46 PM, David Ahern wrote: On 7/31/19 1:45 PM, Jiri Pirko wrote: >> check. e.g., what happens if a resource

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-02 Thread David Ahern
On 8/2/19 1:48 AM, Jiri Pirko wrote: > Wed, Jul 31, 2019 at 09:58:10PM CEST, dsah...@gmail.com wrote: >> On 7/31/19 1:46 PM, David Ahern wrote: >>> On 7/31/19 1:45 PM, Jiri Pirko wrote: > check. e.g., what happens if a resource controller has been configured > for the devlink instance and i

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-02 Thread Jiri Pirko
Wed, Jul 31, 2019 at 09:58:10PM CEST, dsah...@gmail.com wrote: >On 7/31/19 1:46 PM, David Ahern wrote: >> On 7/31/19 1:45 PM, Jiri Pirko wrote: check. e.g., what happens if a resource controller has been configured for the devlink instance and it is moved to a namespace whose existing >>>

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-02 Thread Jiri Pirko
Wed, Jul 31, 2019 at 09:46:13PM CEST, dsah...@gmail.com wrote: >On 7/31/19 1:45 PM, Jiri Pirko wrote: >>> check. e.g., what happens if a resource controller has been configured >>> for the devlink instance and it is moved to a namespace whose existing >>> config exceeds those limits? >> >> It's mo

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread David Ahern
On 7/31/19 1:58 PM, David Ahern wrote: > On 7/31/19 1:46 PM, David Ahern wrote: >> On 7/31/19 1:45 PM, Jiri Pirko wrote: check. e.g., what happens if a resource controller has been configured for the devlink instance and it is moved to a namespace whose existing config exceeds those

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread David Ahern
On 7/31/19 1:46 PM, David Ahern wrote: > On 7/31/19 1:45 PM, Jiri Pirko wrote: >>> check. e.g., what happens if a resource controller has been configured >>> for the devlink instance and it is moved to a namespace whose existing >>> config exceeds those limits? >> >> It's moved with all the values.

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread David Ahern
On 7/31/19 1:45 PM, Jiri Pirko wrote: >> check. e.g., what happens if a resource controller has been configured >> for the devlink instance and it is moved to a namespace whose existing >> config exceeds those limits? > > It's moved with all the values. The whole instance is moved. > The values

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread Jiri Pirko
Wed, Jul 31, 2019 at 09:41:10PM CEST, dsah...@gmail.com wrote: >On 7/31/19 1:26 PM, Jiri Pirko wrote: >> Wed, Jul 31, 2019 at 12:39:52AM CEST, jakub.kicin...@netronome.com wrote: >>> On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote: From: Jiri Pirko All devlink instances are cre

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread David Ahern
On 7/31/19 1:26 PM, Jiri Pirko wrote: > Wed, Jul 31, 2019 at 12:39:52AM CEST, jakub.kicin...@netronome.com wrote: >> On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> All devlink instances are created in init_net and stay there for a >>> lifetime. Allow user to be

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-31 Thread Jiri Pirko
Wed, Jul 31, 2019 at 12:39:52AM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> All devlink instances are created in init_net and stay there for a >> lifetime. Allow user to be able to move devlink instances into >> namesp

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-07-30 Thread Jakub Kicinski
On Tue, 30 Jul 2019 10:57:32 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > All devlink instances are created in init_net and stay there for a > lifetime. Allow user to be able to move devlink instances into > namespaces. > > Signed-off-by: Jiri Pirko I'm no namespace expert, but seems reason