Re: [patch net] net: fec: cache statistics while device is down

2016-11-28 Thread Nikita Yushchenko
> > > >+ fec_enet_update_ethtool_stats(ndev); > >+ > If user never open the interface, ethtool_stats[] always is 0 that are not > expected. > So, it also should be called at . fec_enet_init() ? I don't think that zero stats is wrong for never-opened interface. However a call at init path wo

RE: [patch net] net: fec: cache statistics while device is down

2016-11-28 Thread Andy Duan
From: Nikita Yushchenko Sent: Monday, November 28, 2016 10:27 PM >To: David S. Miller ; Andy Duan >; Troy Kisky ; >Andrew Lunn ; Eric Nelson ; Philippe >Reynes ; Johannes Berg ; >netdev@vger.kernel.org >Cc: Chris Healy ; Fabio Estevam >; linux-ker...@vger.kernel.org; Nikita >Yushchenko