Re: [patch] ifb double-counts packets

2007-01-01 Thread David Miller
From: dean gaudet <[EMAIL PROTECTED]> Date: Sat, 23 Dec 2006 13:58:24 -0800 (PST) > On Sat, 23 Dec 2006, jamal wrote: > > > On Sat, 2006-23-12 at 02:35 -0800, dean gaudet wrote: > > > it seems that ifb counts packets twice... both at xmit time and also in > > > the tasklet. i'm not sure which o

Re: [patch] ifb double-counts packets

2006-12-26 Thread jamal
On Sat, 2006-23-12 at 13:58 -0800, dean gaudet wrote: > Signed-off-by: dean gaudet <[EMAIL PROTECTED]> Acked-by: Jamal Hadi Salim <[EMAIL PROTECTED]> cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [patch] ifb double-counts packets

2006-12-23 Thread dean gaudet
On Sat, 23 Dec 2006, jamal wrote: > On Sat, 2006-23-12 at 02:35 -0800, dean gaudet wrote: > > it seems that ifb counts packets twice... both at xmit time and also in > > the tasklet. i'm not sure which one of the two to drop, but here's a > > patch for dropping the counting at xmit time. > > G

Re: [patch] ifb double-counts packets

2006-12-23 Thread jamal
On Sat, 2006-23-12 at 02:35 -0800, dean gaudet wrote: > it seems that ifb counts packets twice... both at xmit time and also in > the tasklet. i'm not sure which one of the two to drop, but here's a > patch for dropping the counting at xmit time. Good catch but not quite right. The correct way