Re: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-06-26 Thread Calvin Johnson
Hi Andrew On Fri, Jun 26, 2020 at 03:39:42PM +0200, Andrew Lunn wrote: > > Hi Andrew > > > > As you know, making this code generic would bring us back to waiting for > > ACPI team's approval which is very difficult to get as the ACPI doesn't > > have any opinion on MDIO bus. > > > > Like other A

Re: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-06-26 Thread Andrew Lunn
> Hi Andrew > > As you know, making this code generic would bring us back to waiting for > ACPI team's approval which is very difficult to get as the ACPI doesn't > have any opinion on MDIO bus. > > Like other ACPI ethernet drivers, can't we keep it local to this driver to > avoid the above issue

Re: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-06-26 Thread Calvin Johnson
On Thu, Jun 25, 2020 at 09:42:11PM +0200, Andrew Lunn wrote: > On Thu, Jun 25, 2020 at 10:05:38AM +0530, Calvin Johnson wrote: > > > +static struct phy_device *dpaa2_find_phy_device(struct fwnode_handle > > *fwnode) > > +{ > > + struct fwnode_reference_args args; > > + struct platform_device

Re: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-06-25 Thread Andrew Lunn
On Thu, Jun 25, 2020 at 10:05:38AM +0530, Calvin Johnson wrote: > +static struct phy_device *dpaa2_find_phy_device(struct fwnode_handle *fwnode) > +{ > + struct fwnode_reference_args args; > + struct platform_device *pdev; > + struct mii_bus *mdio; > + struct device *dev; > + a

Re: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-06-25 Thread Calvin Johnson
Hi Ioana, On Thu, Jun 25, 2020 at 07:59:19AM +, Ioana Ciornei wrote: > > Subject: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC > > driver > > > > Modify dpaa2_mac_connect() to support ACPI along with DT. > > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either

RE: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-06-25 Thread Ioana Ciornei
> Subject: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC > driver > > Modify dpaa2_mac_connect() to support ACPI along with DT. > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or > ACPI. > Replace of_get_phy_mode() with fwnode_get_phy_mode() to get phy-mod