Re: [net] fq_codel: fix NET_XMIT_CN behavior

2016-06-04 Thread Eric Dumazet
On Sat, 2016-06-04 at 21:03 +0200, Florian Westphal wrote: > Is skb still valid here? AFAICS its possible that fq_codel_drop() drops it. > > Other than that this looks good, thanks Eric! You are are right. skb is guaranteed to be valid only when we return NET_XMIT_SUCCESS. I'll send a V2, thank

Re: [net] fq_codel: fix NET_XMIT_CN behavior

2016-06-04 Thread Florian Westphal
Eric Dumazet wrote: > From: Eric Dumazet > > My prior attempt to fix the backlogs of parents failed. > > If we return NET_XMIT_CN, our parents wont increase their backlog, > so our qdisc_tree_reduce_backlog() should take this into account. [..] > diff --git a/net/sched/sch_fq_codel.c b/net/sc