Re: [alsa-devel] don't pass a NULL struct device to DMA API functions

2019-02-01 Thread Takashi Iwai
On Fri, 01 Feb 2019 17:09:57 +0100, Christoph Hellwig wrote: > > On Fri, Feb 01, 2019 at 02:16:08PM +0100, Takashi Iwai wrote: > > Actually there are a bunch of ISA sound drivers that still call > > allocators with NULL device. > > > > The patch below should address it, although it's only compile

Re: [alsa-devel] don't pass a NULL struct device to DMA API functions

2019-02-01 Thread Christoph Hellwig
On Fri, Feb 01, 2019 at 02:16:08PM +0100, Takashi Iwai wrote: > Actually there are a bunch of ISA sound drivers that still call > allocators with NULL device. > > The patch below should address it, although it's only compile-tested. Oh, I missed these "indirect" calls. This looks good to me: Re

Re: [alsa-devel] don't pass a NULL struct device to DMA API functions

2019-02-01 Thread Takashi Iwai
On Fri, 01 Feb 2019 09:47:43 +0100, Christoph Hellwig wrote: > > We still have a few drivers which pass a NULL struct device pointer > to DMA API functions, which generally is a bad idea as the API > implementations rely on the device not only for ops selection, but > also the dma mask and various