Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits

2007-05-18 Thread jamal
On Wed, 2007-16-05 at 23:25 -0400, jamal wrote: > > This patch now includes two changed drivers (tun and e1000). I have > tested tun with this patch. I tested e1000 earlier and i couldnt find > any issues - although as the tittle says its a WIP. > > As before you need net-2.6. You also need the

Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits

2007-05-16 Thread Krishna Kumar2
Sridhar Samudrala <[EMAIL PROTECTED]> wrote on 05/17/2007 03:14:41 AM: > Krishna Kumar2 wrote: > > Hi Sridhar, > > > > Sridhar Samudrala <[EMAIL PROTECTED]> wrote on 05/17/2007 03:42:03 AM: > > > >> AFAIK, gso_skb can be a list of skb's. Can we add a list > >> to another list using __skb_queue_hea

Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits

2007-05-16 Thread Sridhar Samudrala
Krishna Kumar2 wrote: Hi Sridhar, Sridhar Samudrala <[EMAIL PROTECTED]> wrote on 05/17/2007 03:42:03 AM: AFAIK, gso_skb can be a list of skb's. Can we add a list to another list using __skb_queue_head()? Also, if gso_skb is a list of multiple skb's, i think the count needs to be decremented by

Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits

2007-05-16 Thread Krishna Kumar2
Hi Sridhar, Sridhar Samudrala <[EMAIL PROTECTED]> wrote on 05/17/2007 03:42:03 AM: > AFAIK, gso_skb can be a list of skb's. Can we add a list > to another list using __skb_queue_head()? > Also, if gso_skb is a list of multiple skb's, i think the > count needs to be decremented by the number of se

Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits

2007-05-16 Thread jamal
On Wed, 2007-16-05 at 18:52 -0400, jamal wrote: > On Wed, 2007-16-05 at 15:12 -0700, Sridhar Samudrala wrote: > > I will have to think a bit about this; i may end up coalescing when > grabbing the packets but call the nit from the driver using a helper. > Thats what i did. This would hopefully

Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits

2007-05-16 Thread jamal
On Wed, 2007-16-05 at 15:12 -0700, Sridhar Samudrala wrote: > Jamal, > > Here are some comments i have on your patch. > See them inline. > Thanks for taking the time Sridhar. > try_tx_pkts() is directly calling the device's batch xmit routine. > Don't we need to call dev_hard_start_xmit() to ha

Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits

2007-05-16 Thread Sridhar Samudrala
Jamal, Here are some comments i have on your patch. See them inline. Thanks Sridhar +static int try_get_tx_pkts(struct net_device *dev, struct Qdisc *q, int count) +{ + struct sk_buff *skb; + struct sk_buff_head *skbs = &dev->blist; + int tdq = count; + + /* +* v

Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits

2007-05-15 Thread jamal
On Tue, 2007-15-05 at 18:48 -0400, jamal wrote: > I will try to post the e1000 patch tonight or tommorow morning. I have the e1000 path done; a few features from the 2.6.18 missing (mainly the one mucking with tx ring pruning on the tx path). While it compiles and looks right - i havent tested it

Re: [WIP] [PATCH] WAS Re: [RFC] New driver API to speed up small packets xmits

2007-05-15 Thread jamal
On Tue, 2007-15-05 at 18:17 -0400, jamal wrote: > I will post a patch for tun device in a few minutes > that i use to test on my laptop (i need to remove some debugs) to show > an example. Ok, here it is. The way i test is to point packets at a tun device. [One way i do it is attach an ingress q