Re: [RFC net-next] net: phy: at803x: add cable diagnostics support

2020-05-06 Thread Matthias May
On 03/05/2020 20:15, Michael Walle wrote: > The AR8031/AR8033 and the AR8035 support cable diagnostics. Adding > driver support is straightforward, so lets add it. > > The PHY just do one pair at a time, so we have to start the test four > times. The cable_test_get_status() can block and therefore

Re: [RFC net-next] net: phy: at803x: add cable diagnostics support

2020-05-06 Thread Michael Walle
Am 2020-05-06 11:01, schrieb Matthias May: I've worked with this PHY quite often and we've hacked together some support for the CDT in uboot. Have you done any tests with the cable on the other side being plugged in? yes With the cable being plugged in, we something (1 out of 10 or so) obs

Re: [RFC net-next] net: phy: at803x: add cable diagnostics support

2020-05-05 Thread Michael Walle
Am 2020-05-05 15:07, schrieb Andrew Lunn: +static int at803x_cable_test_get_status(struct phy_device *phydev, + bool *finished) +{ + struct at803x_priv *priv = phydev->priv; + static const int ethtool_pair[] = { + ETHTOOL_A_CABLE_PAI

Re: [RFC net-next] net: phy: at803x: add cable diagnostics support

2020-05-05 Thread Andrew Lunn
> +static int at803x_cable_test_get_status(struct phy_device *phydev, > + bool *finished) > +{ > + struct at803x_priv *priv = phydev->priv; > + static const int ethtool_pair[] = { > + ETHTOOL_A_CABLE_PAIR_0, ETHTOOL_A_CABLE_PAIR_1, > +