Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-30 Thread Jakub Kicinski
On Wed, 30 Sep 2020 10:58:00 +0200 Paolo Abeni wrote: > On Tue, 2020-09-29 at 14:48 -0700, Jakub Kicinski wrote: > > On Tue, 29 Sep 2020 13:16:59 -0700 Wei Wang wrote: > > > On Tue, Sep 29, 2020 at 12:19 PM Jakub Kicinski wrote: > > > > On Mon, 28 Sep 2020 19:43:36 +0200 Eric Dumazet wrote:

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-30 Thread Paolo Abeni
On Tue, 2020-09-29 at 14:48 -0700, Jakub Kicinski wrote: > On Tue, 29 Sep 2020 13:16:59 -0700 Wei Wang wrote: > > On Tue, Sep 29, 2020 at 12:19 PM Jakub Kicinski wrote: > > > On Mon, 28 Sep 2020 19:43:36 +0200 Eric Dumazet wrote: > > > > Wei, this is a very nice work. > > > > > > > > Please re-

RE: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-30 Thread David Laight
From: Jakub Kicinski > Sent: 29 September 2020 22:49 ... > Isn't the fundamental problem that scheduler works at ms scale while > where we're talking about 100us at most? And AFAICT scheduler doesn't > have a knob to adjust migration cost per process? :( Have you tried setting the application proc

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-29 Thread Jakub Kicinski
On Tue, 29 Sep 2020 13:16:59 -0700 Wei Wang wrote: > On Tue, Sep 29, 2020 at 12:19 PM Jakub Kicinski wrote: > > On Mon, 28 Sep 2020 19:43:36 +0200 Eric Dumazet wrote: > > > Wei, this is a very nice work. > > > > > > Please re-send it without the RFC tag, so that we can hopefully merge it > > >

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-29 Thread Jakub Kicinski
On Mon, 28 Sep 2020 19:43:36 +0200 Eric Dumazet wrote: > Wei, this is a very nice work. > > Please re-send it without the RFC tag, so that we can hopefully merge it ASAP. The problem is for the application I'm testing with this implementation is significantly slower (in terms of RPS) than Felix's

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-28 Thread Magnus Karlsson
On Fri, Sep 25, 2020 at 9:06 PM Jakub Kicinski wrote: > > On Fri, 25 Sep 2020 15:48:35 +0200 Magnus Karlsson wrote: > > I really like this RFC and would encourage you to submit it as a > > patch. Would love to see it make it into the kernel. > > > > I see the same positive effects as you when tryi

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-25 Thread Jakub Kicinski
On Fri, 25 Sep 2020 15:48:35 +0200 Magnus Karlsson wrote: > I really like this RFC and would encourage you to submit it as a > patch. Would love to see it make it into the kernel. > > I see the same positive effects as you when trying it out with AF_XDP > sockets. Made some simple experiments wher

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-25 Thread Stephen Hemminger
On Fri, 25 Sep 2020 20:23:37 +0200 Eric Dumazet wrote: > On Fri, Sep 25, 2020 at 8:16 PM Stephen Hemminger > wrote: > > > > On Fri, 25 Sep 2020 10:15:25 -0700 > > Wei Wang wrote: > > > > > > > In terms of performance, I ran tcp_rr tests with 1000 flows with > > > > > various request/response

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-25 Thread Stephen Hemminger
On Fri, 25 Sep 2020 10:15:25 -0700 Wei Wang wrote: > > > In terms of performance, I ran tcp_rr tests with 1000 flows with > > > various request/response sizes, with RFS/RPS disabled, and compared > > > performance between softirq vs kthread. Host has 56 hyper threads and > > > 100Gbps nic. It wo

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-25 Thread Eric Dumazet
On 9/25/20 7:15 PM, Wei Wang wrote: > On Fri, Sep 25, 2020 at 6:48 AM Magnus Karlsson > wrote: >> >> On Mon, Sep 14, 2020 at 7:26 PM Wei Wang wrote: >>> >>> The idea of moving the napi poll process out of softirq context to a >>> kernel thread based context is not new. >>> Paolo Abeni and Hann

Re: [RFC PATCH net-next 0/6] implement kthread based napi poll

2020-09-25 Thread Magnus Karlsson
On Mon, Sep 14, 2020 at 7:26 PM Wei Wang wrote: > > The idea of moving the napi poll process out of softirq context to a > kernel thread based context is not new. > Paolo Abeni and Hannes Frederic Sowa has proposed patches to move napi > poll to kthread back in 2016. And Felix Fietkau has also pro