Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-10-04 Thread John W. Linville
On Thu, Oct 04, 2018 at 05:06:29PM +0100, Edward Cree wrote: > On 04/10/18 15:08, John W. Linville wrote: > > Ping? > > > > On Mon, Oct 01, 2018 at 02:59:10PM -0400, John W. Linville wrote: > >> Is this patch still RFC? > Feel free to de-RFC and apply it. Great -- queued for next release. John --

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-10-04 Thread Edward Cree
On 04/10/18 15:08, John W. Linville wrote: > Ping? > > On Mon, Oct 01, 2018 at 02:59:10PM -0400, John W. Linville wrote: >> Is this patch still RFC? Feel free to de-RFC and apply it.

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-10-04 Thread Michal Kubecek
On Thu, Oct 04, 2018 at 10:08:14AM -0400, John W. Linville wrote: > Ping? > > On Mon, Oct 01, 2018 at 02:59:10PM -0400, John W. Linville wrote: > > Is this patch still RFC? As far as I'm concerned, it can be taken as it is. Michal Kubecek > > > > On Wed, Sep 19, 2018 at 05:06:25PM +0100, Edwar

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-10-04 Thread John W. Linville
Ping? On Mon, Oct 01, 2018 at 02:59:10PM -0400, John W. Linville wrote: > Is this patch still RFC? > > On Wed, Sep 19, 2018 at 05:06:25PM +0100, Edward Cree wrote: > > Instead of commas, just have them as separate argvs. > > > > The parsing state machine might look heavyweight, but it makes it e

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-10-01 Thread John W. Linville
Is this patch still RFC? On Wed, Sep 19, 2018 at 05:06:25PM +0100, Edward Cree wrote: > Instead of commas, just have them as separate argvs. > > The parsing state machine might look heavyweight, but it makes it easy to add > more parameters later and distinguish parameter names from encoding nam

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-09-20 Thread Michal Kubecek
On Wed, Sep 19, 2018 at 05:06:25PM +0100, Edward Cree wrote: > Instead of commas, just have them as separate argvs. > > The parsing state machine might look heavyweight, but it makes it easy to add > more parameters later and distinguish parameter names from encoding names. > > Suggested-by: Mic