Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-22 Thread Linus Torvalds
On Thu, Mar 22, 2018 at 3:48 AM, David Laight wrote: > From: Linus Torvalds >> >> Note that we definitely have seen hardware that *depends* on the >> regular memcpy_fromio()" not doing big reads. I don't know how >> hardware people screw it up, but it's clearly possible. [ That should have been "

RE: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-22 Thread David Laight
From: Linus Torvalds > Sent: 22 March 2018 01:27 > On Tue, Mar 20, 2018 at 7:42 AM, Alexander Duyck > wrote: > > > > Instead of framing this as an enhanced version of the read/write ops > > why not look at replacing or extending something like the > > memcpy_fromio or memcpy_toio operations? > >

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Linus Torvalds
On Tue, Mar 20, 2018 at 7:42 AM, Alexander Duyck wrote: > > Instead of framing this as an enhanced version of the read/write ops > why not look at replacing or extending something like the > memcpy_fromio or memcpy_toio operations? Yes, doing something like "memcpy_fromio_avx()" is much more pala

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Rahul Lakkireddy
On Tuesday, March 03/20/18, 2018 at 20:12:15 +0530, Alexander Duyck wrote: > On Tue, Mar 20, 2018 at 6:32 AM, Rahul Lakkireddy > wrote: > > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: > >> > >> > Use VMOVDQU AVX CPU in

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Rahul Lakkireddy
On Tuesday, March 03/20/18, 2018 at 20:10:19 +0530, David Laight wrote: > From: Rahul Lakkireddy > > Sent: 20 March 2018 13:32 > ... > > On High Availability Server, the logs of the failing system must be > > collected as quickly as possible. So, we're concerned with the amount > > of time taken t

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Rahul Lakkireddy
On Tuesday, March 03/20/18, 2018 at 19:14:46 +0530, Andy Shevchenko wrote: > On Tue, Mar 20, 2018 at 3:32 PM, Rahul Lakkireddy > wrote: > > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: > > >> Aside of that I very much

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread Alexander Duyck
On Tue, Mar 20, 2018 at 6:32 AM, Rahul Lakkireddy wrote: > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: >> >> > Use VMOVDQU AVX CPU instruction when available to do 256-bit >> > IO read and write. >> >> That's not what th

RE: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread David Laight
From: Rahul Lakkireddy > Sent: 20 March 2018 13:32 ... > On High Availability Server, the logs of the failing system must be > collected as quickly as possible. So, we're concerned with the amount > of time taken to collect our large on-chip memory. We see improvement > in doing 256-bit reads at

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread Andy Shevchenko
On Tue, Mar 20, 2018 at 3:32 PM, Rahul Lakkireddy wrote: > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: >> Aside of that I very much doubt that this is faster than 4 consecutive >> 64bit reads/writes as you have the full

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: > > > Use VMOVDQU AVX CPU instruction when available to do 256-bit > > IO read and write. > > That's not what the patch does. See below. > > > Signed-off-by: Rahul Lakkireddy

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-19 Thread Thomas Gleixner
On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: > Use VMOVDQU AVX CPU instruction when available to do 256-bit > IO read and write. That's not what the patch does. See below. > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar That Signed-off-by chain is wrong > +#ifdef CONFIG_