On Fri, May 27, 2016 at 03:35:57PM -0400, Vivien Didelot wrote:
> Hi Andrew,
>
> Andrew Lunn writes:
>
> > @@ -26,6 +26,7 @@ enum dsa_tag_protocol {
> > DSA_TAG_PROTO_TRAILER,
> > DSA_TAG_PROTO_EDSA,
> > DSA_TAG_PROTO_BRCM,
> > + _DSA_TAG_LAST,
> > };
>
> I would avoid _ prefixed
Hi Andrew,
Andrew Lunn writes:
> @@ -26,6 +26,7 @@ enum dsa_tag_protocol {
> DSA_TAG_PROTO_TRAILER,
> DSA_TAG_PROTO_EDSA,
> DSA_TAG_PROTO_BRCM,
> + _DSA_TAG_LAST,
> };
I would avoid _ prefixed functions or symbols, we've seen in mv88e6xxx
that it doesn't make the code rea
