Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops

2016-09-01 Thread Tom Lendacky
On 08/31/2016 07:50 PM, Tom Lendacky wrote: > On 08/31/2016 04:17 PM, David Miller wrote: >> From: Stephen Hemminger >> Date: Wed, 31 Aug 2016 08:57:36 -0700 >> >>> Casting away const is bad practice. Since this is ARM specific driver >>> don't have hardware actually test this. >>> >>> Having gett

Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops

2016-08-31 Thread Tom Lendacky
On 08/31/2016 04:17 PM, David Miller wrote: > From: Stephen Hemminger > Date: Wed, 31 Aug 2016 08:57:36 -0700 > >> Casting away const is bad practice. Since this is ARM specific driver >> don't have hardware actually test this. >> >> Having getter functions for ops is really unnecessary code bloa

Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops

2016-08-31 Thread David Miller
From: Stephen Hemminger Date: Wed, 31 Aug 2016 08:57:36 -0700 > Casting away const is bad practice. Since this is ARM specific driver > don't have hardware actually test this. > > Having getter functions for ops is really unnecessary code bloat, but > not going to touch that. > > Signed-off-by: