On Thu, 1 Apr 2021 08:31:05 -0600
David Ahern wrote:
> On 3/31/21 9:49 PM, Stephen Hemminger wrote:
> > @@ -5681,14 +5682,29 @@ static int inet6_set_iftoken(struct inet6_dev
> > *idev, struct in6_addr *token)
> >
> > ASSERT_RTNL();
> >
> > - if (!token)
> > + if (!token) {
>
> You
On 3/31/21 9:49 PM, Stephen Hemminger wrote:
> @@ -5681,14 +5682,29 @@ static int inet6_set_iftoken(struct inet6_dev *idev,
> struct in6_addr *token)
>
> ASSERT_RTNL();
>
> - if (!token)
> + if (!token) {
You forgot to add a message here.
> return -EINVAL;
> -
On Wed, Mar 31, 2021 at 08:49:02PM -0700, Stephen Hemminger wrote:
> Perhaps the following (NOT TESTED) kernel patch will show you how such error
> messages
> could be added.
This is an elegant solution. I found extack is extensively used in
the other parts of the kernel code for similar purpose
