Re: [RFC/PATCH 2/2] update sunrpc to use in-kernel sockets API

2006-06-13 Thread James Morris
On Tue, 13 Jun 2006, Sridhar Samudrala wrote: > My patch doesn't touch this section of the code and this is called > after the assignment we are talking about. So we should be using the > right sendpage in the actual call. Ok. Acked-by: James Morris <[EMAIL PROTECTED]> (for both patches). --

Re: [RFC/PATCH 2/2] update sunrpc to use in-kernel sockets API

2006-06-13 Thread Sridhar Samudrala
On Tue, 2006-06-13 at 10:07 -0400, James Morris wrote: > On Mon, 12 Jun 2006, Sridhar Samudrala wrote: > > > > > - sendpage = sock->ops->sendpage ? : sock_no_sendpage; > > > > + sendpage = kernel_sendpage ? : sock_no_sendpage; > > > > > > > > > > This is not equivalent. > > > >

Re: [RFC/PATCH 2/2] update sunrpc to use in-kernel sockets API

2006-06-13 Thread James Morris
On Mon, 12 Jun 2006, Sridhar Samudrala wrote: > > > - sendpage = sock->ops->sendpage ? : sock_no_sendpage; > > > + sendpage = kernel_sendpage ? : sock_no_sendpage; > > > > > > > This is not equivalent. > > > > > Actually, we could make this a simple assignment as we check for > sock->ops

Re: [RFC/PATCH 2/2] update sunrpc to use in-kernel sockets API

2006-06-12 Thread Sridhar Samudrala
James Morris wrote: On Mon, 12 Jun 2006, Sridhar Samudrala wrote: - sendpage = sock->ops->sendpage ? : sock_no_sendpage; + sendpage = kernel_sendpage ? : sock_no_sendpage; This is not equivalent. Actually, we could make this a simple assignment as we check for sock->o

Re: [RFC/PATCH 2/2] update sunrpc to use in-kernel sockets API

2006-06-12 Thread James Morris
On Mon, 12 Jun 2006, Sridhar Samudrala wrote: > - sendpage = sock->ops->sendpage ? : sock_no_sendpage; > + sendpage = kernel_sendpage ? : sock_no_sendpage; This is not equivalent. -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in