Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-31 Thread David Miller
From: Cong Wang Date: Wed, 30 Aug 2017 14:30:36 -0700 > TC filters when used as classifiers are bound to TC classes. > However, there is a hidden difference when adding them in different > orders: > > 1. If we add tc classes before its filters, everything is fine. >Logically, the classes exi

Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Cong Wang
On Wed, Aug 30, 2017 at 3:45 PM, Daniel Borkmann wrote: > On 08/31/2017 12:22 AM, Daniel Borkmann wrote: >> >> The prog->res.classid is the default one, but can be overridden >> later depending on the specified program. cls_bpf_classify() does >> after prog return (filter_res holds return code): >

Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Daniel Borkmann
On 08/31/2017 12:22 AM, Daniel Borkmann wrote: On 08/31/2017 12:01 AM, Cong Wang wrote: On Wed, Aug 30, 2017 at 2:48 PM, Daniel Borkmann wrote: On 08/30/2017 11:30 PM, Cong Wang wrote: [...] Note, we still can NOT totally get rid of those class lookup in ->enqueue() because cgroup and flow f

Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Daniel Borkmann
On 08/31/2017 12:01 AM, Cong Wang wrote: On Wed, Aug 30, 2017 at 2:48 PM, Daniel Borkmann wrote: On 08/30/2017 11:30 PM, Cong Wang wrote: [...] Note, we still can NOT totally get rid of those class lookup in ->enqueue() because cgroup and flow filters have no way to determine the classid at s

Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Cong Wang
On Wed, Aug 30, 2017 at 2:48 PM, Daniel Borkmann wrote: > On 08/30/2017 11:30 PM, Cong Wang wrote: > [...] >> >> Note, we still can NOT totally get rid of those class lookup in >> ->enqueue() because cgroup and flow filters have no way to determine >> the classid at setup time, they still have to

Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Daniel Borkmann
On 08/30/2017 11:30 PM, Cong Wang wrote: [...] Note, we still can NOT totally get rid of those class lookup in ->enqueue() because cgroup and flow filters have no way to determine the classid at setup time, they still have to go through dynamic lookup. [...] --- include/net/sch_generic.h | 1