Re: [Patch net] can: initialize skbcnt in j1939_tp_tx_dat_new()

2020-10-08 Thread Marc Kleine-Budde
On 10/9/20 12:26 AM, Jakub Kicinski wrote: > On Thu, 8 Oct 2020 23:47:38 +0200 Marc Kleine-Budde wrote: >>> Marc - should I take this directly into net, in case there is a last >>> minute PR to Linus for 5.9? >> >> Yes, of you can pull Cong Wang's patch and my patch, that fixes the other >> missi

Re: [Patch net] can: initialize skbcnt in j1939_tp_tx_dat_new()

2020-10-08 Thread Jakub Kicinski
On Thu, 8 Oct 2020 23:47:38 +0200 Marc Kleine-Budde wrote: > > Marc - should I take this directly into net, in case there is a last > > minute PR to Linus for 5.9? > > Yes, of you can pull Cong Wang's patch and my patch, that fixes the other > missing init of skbcnt. > > That tag includes my pr

Re: [Patch net] can: initialize skbcnt in j1939_tp_tx_dat_new()

2020-10-08 Thread Marc Kleine-Budde
On 10/8/20 7:34 PM, Jakub Kicinski wrote: > On Wed, 7 Oct 2020 23:18:21 -0700 Cong Wang wrote: >> This fixes an uninit-value warning: >> BUG: KMSAN: uninit-value in can_receive+0x26b/0x630 net/can/af_can.c:650 >> >> Reported-and-tested-by: syzbot+3f3837e61a48d32b4...@syzkaller.appspotmail.com >> F

Re: [Patch net] can: initialize skbcnt in j1939_tp_tx_dat_new()

2020-10-08 Thread Cong Wang
On Thu, Oct 8, 2020 at 10:34 AM Jakub Kicinski wrote: > > On Wed, 7 Oct 2020 23:18:21 -0700 Cong Wang wrote: > > This fixes an uninit-value warning: > > BUG: KMSAN: uninit-value in can_receive+0x26b/0x630 net/can/af_can.c:650 > > > > Reported-and-tested-by: > > syzbot+3f3837e61a48d32b4...@syzkal

Re: [Patch net] can: initialize skbcnt in j1939_tp_tx_dat_new()

2020-10-08 Thread Jakub Kicinski
On Wed, 7 Oct 2020 23:18:21 -0700 Cong Wang wrote: > This fixes an uninit-value warning: > BUG: KMSAN: uninit-value in can_receive+0x26b/0x630 net/can/af_can.c:650 > > Reported-and-tested-by: syzbot+3f3837e61a48d32b4...@syzkaller.appspotmail.com > Fixes: 9d71dd0c7009 ("can: add support of SAE J19