Hi Michal,
On Thu, Sep 21, 2017 at 09:34:20AM +0200, Michal Kubecek wrote:
> I will have to check but IIRC it might be possible to use zero length
> for the peek to only check the length which could help you to avoid both
> the reallocation and copying the same data from kernel to userspace
> twic
On Thu, Sep 21, 2017 at 03:20:02PM +0800, Hangbin Liu wrote:
>
> Or maybe we can set buf_len very small first. Then it will force to realloc at
> the second time. And the code would like
>
> int buf_len = 16;
> bufp = realloc(buf, buf_len);
> /* check bufp and set msg */
>
>
Hi Stephen,
On Wed, Sep 20, 2017 at 09:56:05AM -0700, Stephen Hemminger wrote:
> > +realloc:
> > + bufp = realloc(buf, buf_len);
> > +
> > + if (bufp == NULL) {
>
> Minor personal style issue:
> To me, blank lines are like paragraphs in writing.
> Code reads better assignment and condition che
On Wed, 20 Sep 2017 09:43:39 +0800
Hangbin Liu wrote:
Thanks for keeping up on this.
> +realloc:
> + bufp = realloc(buf, buf_len);
> +
> + if (bufp == NULL) {
Minor personal style issue:
To me, blank lines are like paragraphs in writing.
Code reads better assignment and condition check
