Re: [PATCH v6 net-next 07/19] ionic: Add basic adminq support

2019-08-30 Thread Shannon Nelson
On 8/30/19 3:17 PM, David Miller wrote: From: Jakub Kicinski Date: Fri, 30 Aug 2019 15:16:04 -0700 On Fri, 30 Aug 2019 12:31:07 -0700, Shannon Nelson wrote: On 8/29/19 3:52 PM, Jakub Kicinski wrote: On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote: +static void ionic_lif_qcq_deinit(

Re: [PATCH v6 net-next 07/19] ionic: Add basic adminq support

2019-08-30 Thread David Miller
From: Jakub Kicinski Date: Fri, 30 Aug 2019 15:16:04 -0700 > On Fri, 30 Aug 2019 12:31:07 -0700, Shannon Nelson wrote: >> On 8/29/19 3:52 PM, Jakub Kicinski wrote: >> > On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote: >> >> +static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struc

Re: [PATCH v6 net-next 07/19] ionic: Add basic adminq support

2019-08-30 Thread Jakub Kicinski
On Fri, 30 Aug 2019 12:31:07 -0700, Shannon Nelson wrote: > On 8/29/19 3:52 PM, Jakub Kicinski wrote: > > On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote: > >> +static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq > >> *qcq) > >> +{ > >> + struct ionic_dev *idev = &

Re: [PATCH v6 net-next 07/19] ionic: Add basic adminq support

2019-08-30 Thread Shannon Nelson
On 8/29/19 3:52 PM, Jakub Kicinski wrote: On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote: +static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq *qcq) +{ + struct ionic_dev *idev = &lif->ionic->idev; + struct device *dev = lif->ionic->dev; + + if (!

Re: [PATCH v6 net-next 07/19] ionic: Add basic adminq support

2019-08-29 Thread Jakub Kicinski
On Thu, 29 Aug 2019 11:27:08 -0700, Shannon Nelson wrote: > +static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq > *qcq) > +{ > + struct ionic_dev *idev = &lif->ionic->idev; > + struct device *dev = lif->ionic->dev; > + > + if (!qcq) > + return; > + > +