Re: [PATCH v6 7/8] can-dev: introduce helpers to access Classical CAN DLC values

2020-11-10 Thread Oliver Hartkopp
On 10.11.20 16:50, Marc Kleine-Budde wrote: On 11/10/20 11:18 AM, Oliver Hartkopp wrote: I still think, that can_frame_set_cc_len() makes more sense. See my just posted patches for illustration. Yep. Your patches look fine! Just remove my patches 7 & 8 and apply your suggestions instead.

Re: [PATCH v6 7/8] can-dev: introduce helpers to access Classical CAN DLC values

2020-11-10 Thread Marc Kleine-Budde
On 11/10/20 11:18 AM, Oliver Hartkopp wrote: > can_get_cc_dlc: get the data length code for Classical CAN raw DLC access > can_get_cc_len: get len and len8_dlc value for Classical CAN raw DLC access The final patch needs a bit more prose, like: This patch adds the following helper to functions to