Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling

2019-07-30 Thread Shannon Nelson
On 7/30/19 4:39 PM, Stephen Hemminger wrote: On Mon, 22 Jul 2019 14:40:19 -0700 Shannon Nelson wrote: + +static void ionic_lif_set_netdev_info(struct lif *lif) +{ + struct ionic_admin_ctx ctx = { + .work = COMPLETION_INITIALIZER_ONSTACK(ctx.work), + .cmd.lif_s

Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling

2019-07-30 Thread Stephen Hemminger
On Mon, 22 Jul 2019 14:40:19 -0700 Shannon Nelson wrote: > + > +static void ionic_lif_set_netdev_info(struct lif *lif) > +{ > + struct ionic_admin_ctx ctx = { > + .work = COMPLETION_INITIALIZER_ONSTACK(ctx.work), > + .cmd.lif_setattr = { > + .opcode

Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling

2019-07-30 Thread Shannon Nelson
On 7/25/19 4:55 PM, Saeed Mahameed wrote: On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: When the netdev gets a new name from userland, pass that name down to the NIC for internal tracking. Just out of curiosity, why your NIC internal device/firmware need to keep tracking of the netd

Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling

2019-07-25 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > When the netdev gets a new name from userland, pass that name > down to the NIC for internal tracking. > Just out of curiosity, why your NIC internal device/firmware need to keep tracking of the netdev name ?