Re: [PATCH v4 1/1] drivers core: multi-threading device shutdown

2018-05-15 Thread Pavel Tatashin
Hi Greg, > Can you refactor this to be at least 2 patches? One that moves code > around to comon functions to make the second patch, that adds the new > functionality, easier to review and understand? Yes, I will split the patch into a two-three patches. > And I echo the "don't use kerneldoc f

Re: [PATCH v4 1/1] drivers core: multi-threading device shutdown

2018-05-15 Thread Greg KH
On Mon, May 14, 2018 at 03:42:54PM -0400, Pavel Tatashin wrote: > When system is rebooted, halted or kexeced device_shutdown() is > called. > > This function shuts down every single device by calling either: > > dev->bus->shutdown(dev) > dev->driver->shutdown(dev) > > Even on a machi

Re: [PATCH v4 1/1] drivers core: multi-threading device shutdown

2018-05-14 Thread Pavel Tatashin
Hi Andy, Thank you for your comments. I will send an updated patch soon. My replies are below: On 05/14/2018 04:04 PM, Andy Shevchenko wrote: > Can we still preserve an order here? (Yes, even if the entire list is > not fully ordered) > In the context I see it would go before netdevice.h. Sure

Re: [PATCH v4 1/1] drivers core: multi-threading device shutdown

2018-05-14 Thread Andy Shevchenko
On Mon, May 14, 2018 at 10:42 PM, Pavel Tatashin wrote: > #include > #include > #include > +#include Can we still preserve an order here? (Yes, even if the entire list is not fully ordered) In the context I see it would go before netdevice.h. > +/** > + * device_get_child_by_index - Retu