Re: [PATCH v3 bpf-next 2/4] bpf: add layer 2 encap support to bpf_skb_adjust_room

2019-04-11 Thread Daniel Borkmann
On 04/11/2019 11:18 PM, Willem de Bruijn wrote: [...] >>> diff --git a/net/core/filter.c b/net/core/filter.c >>> index 22eb2ed..a1654ef62 100644 >>> --- a/net/core/filter.c >>> +++ b/net/core/filter.c >>> @@ -2969,11 +2969,14 @@ static u32 bpf_skb_net_base_len(const struct >>> sk_buff *skb) >>> #

Re: [PATCH v3 bpf-next 2/4] bpf: add layer 2 encap support to bpf_skb_adjust_room

2019-04-11 Thread Willem de Bruijn
On Thu, Apr 11, 2019 at 5:09 PM Daniel Borkmann wrote: > > On 04/09/2019 04:06 PM, Alan Maguire wrote: > > commit 868d523535c2 ("bpf: add bpf_skb_adjust_room encap flags") > > introduced support to bpf_skb_adjust_room for GSO-friendly GRE > > and UDP encapsulation. > > > > For GSO to work for skbs

Re: [PATCH v3 bpf-next 2/4] bpf: add layer 2 encap support to bpf_skb_adjust_room

2019-04-11 Thread Daniel Borkmann
On 04/09/2019 04:06 PM, Alan Maguire wrote: > commit 868d523535c2 ("bpf: add bpf_skb_adjust_room encap flags") > introduced support to bpf_skb_adjust_room for GSO-friendly GRE > and UDP encapsulation. > > For GSO to work for skbs, the inner headers (mac and network) need to > be marked. For L3 en