Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-17 Thread David Miller
From: Gregory CLEMENT Date: Thu, 17 Dec 2015 09:39:32 +0100 > if I remebered well you do not remove patch from yout branch. So would > you agree to take a follow-up patch on top of 5833e0526820 "net/macb: > add support for resetting PHY using GPIO" ? Yes. -- To unsubscribe from this list: send

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-17 Thread Gregory CLEMENT
Hi Arnd, On mer., déc. 16 2015, Arnd Bergmann wrote: > On Wednesday 16 December 2015 19:31:30 Gregory CLEMENT wrote: >> diff --git a/drivers/net/ethernet/cadence/macb.c >> b/drivers/net/ethernet/cadence/macb.c >> index 88c1e1a..35661aa 100644 >> --- a/drivers/net/ethernet/cadence/macb.c >> ++

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-16 Thread Arnd Bergmann
On Wednesday 16 December 2015 19:31:30 Gregory CLEMENT wrote: > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c > index 88c1e1a..35661aa 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -28,6 +28,7 @@ > #i

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-16 Thread Gregory CLEMENT
Hi Richard, On mer., déc. 16 2015, Richard Cochran wrote: > On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote: >> +Optional properties for PHY child node: >> +- reset-gpios : Should specify the gpio for phy reset > > reset-gpios plural or reset-gpio singular? The bindings name i

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-16 Thread Richard Cochran
On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote: > +Optional properties for PHY child node: > +- reset-gpios : Should specify the gpio for phy reset reset-gpios plural or reset-gpio singular? > + > Examples: > > macb0: ethernet@fffc4000 { > @@ -29,4 +32,8 @@ Examples: >