Re: [PATCH v3] icmp: support rfc5837

2021-03-19 Thread David Ahern
On 3/19/21 6:53 PM, Willem de Bruijn wrote: > On Fri, Mar 19, 2021 at 7:54 PM David Ahern wrote: >> >> On 3/19/21 10:11 AM, Ishaan Gandhi wrote: >>> Thank you. Would it be better to do instead: >>> >>> + if_index = skb->skb_iif; >>> >>> or >>> >>> + if_index = ip_version == 4 ? inet_iif(sk

Re: [PATCH v3] icmp: support rfc5837

2021-03-19 Thread Willem de Bruijn
On Fri, Mar 19, 2021 at 7:54 PM David Ahern wrote: > > On 3/19/21 10:11 AM, Ishaan Gandhi wrote: > > Thank you. Would it be better to do instead: > > > > + if_index = skb->skb_iif; > > > > or > > > > + if_index = ip_version == 4 ? inet_iif(skb) : skb->skb_iif; > > > > If the packet comes i

Re: [PATCH v3] icmp: support rfc5837

2021-03-19 Thread David Ahern
On 3/19/21 10:11 AM, Ishaan Gandhi wrote: > Thank you. Would it be better to do instead: > > + if_index = skb->skb_iif; > > or > > + if_index = ip_version == 4 ? inet_iif(skb) : skb->skb_iif; > If the packet comes in via an interface assigned to a VRF, skb_iif is most likely the VRF in

Re: [PATCH v3] icmp: support rfc5837

2021-03-19 Thread Ishaan Gandhi
Thank you. Would it be better to do instead: + if_index = skb->skb_iif; or + if_index = ip_version == 4 ? inet_iif(skb) : skb->skb_iif; > On Mar 19, 2021, at 7:55 AM, David Ahern wrote: > > On 3/17/21 4:19 PM, ishaangandhi wrote: >> +void icmp_identify_arrival_interface(struct sk_

Re: [PATCH v3] icmp: support rfc5837

2021-03-19 Thread David Ahern
On 3/17/21 4:19 PM, ishaangandhi wrote: > +void icmp_identify_arrival_interface(struct sk_buff *skb, struct net *net, > int room, > + char *icmph, int ip_version) > +{ > + unsigned int ext_len, orig_len, word_aligned_orig_len, offset, > extra_space_needed, > +