Re: [PATCH v3,net-next] vlan: implement vlan id and protocol changes

2018-06-26 Thread Ido Schimmel
On Tue, Jun 26, 2018 at 09:31:55AM -0400, Chas Williams wrote: > On Mon, Jun 25, 2018 at 4:45 PM David Ahern wrote: > > > On 6/25/18 4:30 AM, Chas Williams wrote: > > > vlan_changelink silently ignores attempts to change the vlan id > > > or protocol id of an existing vlan interface. Implement b

Re: [PATCH v3,net-next] vlan: implement vlan id and protocol changes

2018-06-26 Thread Ido Schimmel
On Tue, Jun 26, 2018 at 09:33:40AM -0400, Chas Williams wrote: > On Tue, Jun 26, 2018 at 6:32 AM Ido Schimmel wrote: > > > On Mon, Jun 25, 2018 at 02:45:24PM -0600, David Ahern wrote: > > > On 6/25/18 4:30 AM, Chas Williams wrote: > > > > vlan_changelink silently ignores attempts to change the vl

Re: [PATCH v3,net-next] vlan: implement vlan id and protocol changes

2018-06-26 Thread Ido Schimmel
On Mon, Jun 25, 2018 at 02:45:24PM -0600, David Ahern wrote: > On 6/25/18 4:30 AM, Chas Williams wrote: > > vlan_changelink silently ignores attempts to change the vlan id > > or protocol id of an existing vlan interface. Implement by adding > > the new vlan id and protocol to the interface's vlan

Re: [PATCH v3,net-next] vlan: implement vlan id and protocol changes

2018-06-25 Thread David Ahern
On 6/25/18 4:30 AM, Chas Williams wrote: > vlan_changelink silently ignores attempts to change the vlan id > or protocol id of an existing vlan interface. Implement by adding > the new vlan id and protocol to the interface's vlan group and then > removing the old vlan id and protocol from the vlan