Re: [PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads

2015-10-20 Thread Wolfgang Walter
Hello Eric! Am Freitag, 16. Oktober 2015, 08:23:49 schrieb Eric Dumazet: > On Thu, 2015-08-06 at 17:15 -0700, Jesse Gross wrote: > > On Mon, Aug 3, 2015 at 10:11 AM, Tom Herbert wrote: > > > For GRO to work with sit we need gro_receive and gro_complete populated > > > in the sit_offload structure

Re: [PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads

2015-10-19 Thread Eric Dumazet
On Fri, 2015-10-16 at 08:23 -0700, Eric Dumazet wrote: > What about the following more complete patch ? > > We properly set skb->encapsulation and inner network header as some NIC > drivers depend on it. Our GSO should also work properly I think. > > Wolfgang, could you please test it ? (this is

Re: [PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads

2015-10-16 Thread Eric Dumazet
On Thu, 2015-08-06 at 17:15 -0700, Jesse Gross wrote: > On Mon, Aug 3, 2015 at 10:11 AM, Tom Herbert wrote: > > For GRO to work with sit we need gro_receive and gro_complete populated > > in the sit_offload structure. > > > > Signed-off-by: Tom Herbert > > You might want to checkout the recent h

Re: [PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads

2015-08-06 Thread Jesse Gross
On Mon, Aug 3, 2015 at 10:11 AM, Tom Herbert wrote: > For GRO to work with sit we need gro_receive and gro_complete populated > in the sit_offload structure. > > Signed-off-by: Tom Herbert You might want to checkout the recent history on this file unless there's something that's changed in the l