Re: [PATCH v2 net-next 1/1] net: dsa: hellcreek: Add TAPRIO offloading support

2021-01-20 Thread Jakub Kicinski
On Wed, 20 Jan 2021 08:18:15 +0100 Kurt Kanzenbach wrote: > >> + /* Schedule periodic schedule check */ > >> + schedule_delayed_work(&hellcreek_port->schedule_work, > >> +HELLCREEK_SCHEDULE_PERIOD); > > > > Why schedule this work every 2 seconds rather than scheduling it

Re: [PATCH v2 net-next 1/1] net: dsa: hellcreek: Add TAPRIO offloading support

2021-01-19 Thread Kurt Kanzenbach
On Tue Jan 19 2021, Jakub Kicinski wrote: > On Sat, 16 Jan 2021 13:49:22 +0100 Kurt Kanzenbach wrote: >> +if (base_time_ns - current_ns < (s64)8 * NSEC_PER_SEC) >> +return true; >> + >> +return false; > > nit: > return base_time_ns - current_ns < (s64)8 * NSEC_PER_SEC; Su

Re: [PATCH v2 net-next 1/1] net: dsa: hellcreek: Add TAPRIO offloading support

2021-01-19 Thread Jakub Kicinski
On Sat, 16 Jan 2021 13:49:22 +0100 Kurt Kanzenbach wrote: > The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic > schedules may be configured individually on each front port. Each port has > eight > egress queues. The traffic is mapped to a traffic class respectively via the

Re: [PATCH v2 net-next 1/1] net: dsa: hellcreek: Add TAPRIO offloading support

2021-01-17 Thread Vladimir Oltean
On Sat, Jan 16, 2021 at 01:49:22PM +0100, Kurt Kanzenbach wrote: > The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic > schedules may be configured individually on each front port. Each port has > eight > egress queues. The traffic is mapped to a traffic class respectively vi