Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-04-01 Thread Andrii Nakryiko
On Thu, Apr 1, 2021 at 12:51 PM Martin KaFai Lau wrote: > > On Tue, Mar 30, 2021 at 11:44:39PM -0700, Andrii Nakryiko wrote: > > On Mon, Mar 29, 2021 at 12:11 PM Martin KaFai Lau wrote: > > > > > > On Mon, Mar 29, 2021 at 05:06:26PM +0100, Lorenz Bauer wrote: > > > > On Mon, 29 Mar 2021 at 02:25,

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-04-01 Thread Martin KaFai Lau
On Tue, Mar 30, 2021 at 11:44:39PM -0700, Andrii Nakryiko wrote: > On Mon, Mar 29, 2021 at 12:11 PM Martin KaFai Lau wrote: > > > > On Mon, Mar 29, 2021 at 05:06:26PM +0100, Lorenz Bauer wrote: > > > On Mon, 29 Mar 2021 at 02:25, Martin KaFai Lau wrote: > > > > > > > > > > > > > > > > > > # pahol

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-30 Thread Andrii Nakryiko
On Mon, Mar 29, 2021 at 12:11 PM Martin KaFai Lau wrote: > > On Mon, Mar 29, 2021 at 05:06:26PM +0100, Lorenz Bauer wrote: > > On Mon, 29 Mar 2021 at 02:25, Martin KaFai Lau wrote: > > > > > > > > > > > > > > > # pahole --version > > > > > > v1.17 > > > > > > > > > > That is the most likely reaso

Re: [External] Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-30 Thread Martin KaFai Lau
On Tue, Mar 30, 2021 at 08:28:34PM -0700, Jiang Wang . wrote: > I am working with Cong to get Clang/LLVM-13 to test. But I am confused > whether CLANG/LLVM-13 is released or not. > > From https://apt.llvm.org/ , I saw llvm-13 was released in Feb, but it > does not have the diff you mentioned. I h

Re: [External] Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-30 Thread Jiang Wang .
Hi Martin, I am working with Cong to get Clang/LLVM-13 to test. But I am confused whether CLANG/LLVM-13 is released or not. >From https://apt.llvm.org/ , I saw llvm-13 was released in Feb, but it does not have the diff you mentioned. >From the following links, I am not sure if LLVM-13 was really

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-30 Thread Martin KaFai Lau
On Tue, Mar 30, 2021 at 12:58:22PM -0700, Cong Wang wrote: > On Tue, Mar 30, 2021 at 7:36 AM Alexei Starovoitov > wrote: > > > > On Tue, Mar 30, 2021 at 2:43 AM Lorenz Bauer wrote: > > > > > > On Thu, 25 Mar 2021 at 01:52, Martin KaFai Lau wrote: > > > > > > > > This series adds support to allow

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-30 Thread Cong Wang
On Tue, Mar 30, 2021 at 7:36 AM Alexei Starovoitov wrote: > > On Tue, Mar 30, 2021 at 2:43 AM Lorenz Bauer wrote: > > > > On Thu, 25 Mar 2021 at 01:52, Martin KaFai Lau wrote: > > > > > > This series adds support to allow bpf program calling kernel function. > > > > I think there are more build

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-30 Thread Alexei Starovoitov
On Tue, Mar 30, 2021 at 2:43 AM Lorenz Bauer wrote: > > On Thu, 25 Mar 2021 at 01:52, Martin KaFai Lau wrote: > > > > This series adds support to allow bpf program calling kernel function. > > I think there are more build problems with this. Has anyone hit this before? > > $ CLANG=clang-12 O=../k

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-30 Thread Lorenz Bauer
On Thu, 25 Mar 2021 at 01:52, Martin KaFai Lau wrote: > > This series adds support to allow bpf program calling kernel function. I think there are more build problems with this. Has anyone hit this before? $ CLANG=clang-12 O=../kbuild/vm ./tools/testing/selftests/bpf/vmtest.sh -j 7 GEN-SKEL [

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-29 Thread Cong Wang
On Sun, Mar 28, 2021 at 6:24 PM Martin KaFai Lau wrote: > Could you also check the CONFIG_DYNAMIC_FTRACE and also try 'y' if it > is not set? On my side, with pahole==1.17, changing CONFIG_DYNAMIC_FTRACE makes no difference. With pahole==1.20, CONFIG_DYNAMIC_FTRACE=y makes it gone, but CONFIG_DYN

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-29 Thread Martin KaFai Lau
On Mon, Mar 29, 2021 at 05:06:26PM +0100, Lorenz Bauer wrote: > On Mon, 29 Mar 2021 at 02:25, Martin KaFai Lau wrote: > > > > > > > > > > > > # pahole --version > > > > > v1.17 > > > > > > > > That is the most likely reason. > > > > In lib/Kconfig.debug > > > > we have pahole >= 1.19 requirement f

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-29 Thread Lorenz Bauer
On Mon, 29 Mar 2021 at 02:25, Martin KaFai Lau wrote: > > > > > > > > > # pahole --version > > > > v1.17 > > > > > > That is the most likely reason. > > > In lib/Kconfig.debug > > > we have pahole >= 1.19 requirement for BTF in modules. > > > Though your config has CUBIC=y I suspect something odd

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-28 Thread Martin KaFai Lau
On Sun, Mar 28, 2021 at 01:13:35PM -0700, Cong Wang wrote: > On Sat, Mar 27, 2021 at 3:54 PM Alexei Starovoitov > wrote: > > > > On Sat, Mar 27, 2021 at 3:08 PM Cong Wang wrote: > > > BTFIDS vmlinux > > > FAILED unresolved symbol cubictcp_state > > > make: *** [Makefile:1199: vmlinux] Error 25

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-28 Thread Cong Wang
On Sat, Mar 27, 2021 at 3:54 PM Alexei Starovoitov wrote: > > On Sat, Mar 27, 2021 at 3:08 PM Cong Wang wrote: > > BTFIDS vmlinux > > FAILED unresolved symbol cubictcp_state > > make: *** [Makefile:1199: vmlinux] Error 255 > > > > I suspect it is related to the kernel config or linker version.

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-27 Thread Alexei Starovoitov
On Sat, Mar 27, 2021 at 3:08 PM Cong Wang wrote: > BTFIDS vmlinux > FAILED unresolved symbol cubictcp_state > make: *** [Makefile:1199: vmlinux] Error 255 > > I suspect it is related to the kernel config or linker version. > > # grep TCP_CONG .config > CONFIG_TCP_CONG_ADVANCED=y > CONFIG_TCP_CO

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-27 Thread Cong Wang
On Sat, Mar 27, 2021 at 2:28 PM Alexei Starovoitov wrote: > > On Sat, Mar 27, 2021 at 2:25 PM Cong Wang wrote: > > > > Hi, > > > > On Wed, Mar 24, 2021 at 8:40 PM Martin KaFai Lau wrote: > > > Martin KaFai Lau (14): > > > bpf: Simplify freeing logic in linfo and jited_linfo > > > bpf: Refact

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-27 Thread Alexei Starovoitov
On Sat, Mar 27, 2021 at 2:25 PM Cong Wang wrote: > > Hi, > > On Wed, Mar 24, 2021 at 8:40 PM Martin KaFai Lau wrote: > > Martin KaFai Lau (14): > > bpf: Simplify freeing logic in linfo and jited_linfo > > bpf: Refactor btf_check_func_arg_match > > bpf: Support bpf program calling kernel fun

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-27 Thread Cong Wang
Hi, On Wed, Mar 24, 2021 at 8:40 PM Martin KaFai Lau wrote: > Martin KaFai Lau (14): > bpf: Simplify freeing logic in linfo and jited_linfo > bpf: Refactor btf_check_func_arg_match > bpf: Support bpf program calling kernel function > bpf: Support kernel function call in x86-32 > tcp: Re

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 24 Mar 2021 18:51:24 -0700 you wrote: > This series adds support to allow bpf program calling kernel function. > > The use case included in this set is to allow bpf-tcp-cc to directly > call some tcp-cc helper functi