Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Scott Branden
Hi Michal, Thanks - one question below hopefully someone can help with. On 17-12-05 02:29 PM, Michal Kubecek wrote: On Tue, Dec 05, 2017 at 02:06:09PM -0800, Scott Branden wrote: On 17-12-05 01:30 PM, Michal Kubecek wrote: On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: Add E

Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Scott Branden
Hi Andrew, On 17-12-05 02:26 PM, Andrew Lunn wrote: On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: Add ETHTOOL_RESET support via --reset command. ie. ethtool --reset DEVNAME flagnames currently match the ETH_RESET_xxx names: mgmt,irq,dma,filter,offload,mac,phy,ram,dedicated

Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Michal Kubecek
On Tue, Dec 05, 2017 at 02:06:09PM -0800, Scott Branden wrote: > On 17-12-05 01:30 PM, Michal Kubecek wrote: > > On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: > > > Add ETHTOOL_RESET support via --reset command. > > > > > > ie. ethtool --reset DEVNAME > > > > > > flagnames curr

Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Andrew Lunn
On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: > Add ETHTOOL_RESET support via --reset command. > > ie. ethtool --reset DEVNAME > > flagnames currently match the ETH_RESET_xxx names: > mgmt,irq,dma,filter,offload,mac,phy,ram,dedicated,all [Snip] > +.B ethtool \-\-reset > +.I d

Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Scott Branden
Hi Michal, thanks for review - see comments On 17-12-05 01:30 PM, Michal Kubecek wrote: On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: Add ETHTOOL_RESET support via --reset command. ie. ethtool --reset DEVNAME flagnames currently match the ETH_RESET_xxx names: mgmt,irq,dma,

Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Michal Kubecek
On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: > Add ETHTOOL_RESET support via --reset command. > > ie. ethtool --reset DEVNAME > > flagnames currently match the ETH_RESET_xxx names: > mgmt,irq,dma,filter,offload,mac,phy,ram,dedicated,all > > Alternatively, you can specific com