Re: [PATCH v2] net: Add trace events for all receive exit points

On Mon, 12 Nov 2018 15:46:53 -0500 (EST) Mathieu Desnoyers wrote: > I also notice that in two cases, a "gro_result_t" is implicitly cast > to "int". I usually frown upon this kind of stuff, because it's asking > for trouble if gro_result_t typedef to something else than "int" in the > future. >

Re: [PATCH v2] net: Add trace events for all receive exit points

- On Nov 12, 2018, at 3:46 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Nov 12, 2018, at 3:40 PM, rostedt rost...@goodmis.org wrote: > >> On Mon, 12 Nov 2018 15:20:55 -0500 (EST) >> Mathieu Desnoyers wrote: >> >>> >>> Hrm, looking at this again, I notice that the

Re: [PATCH v2] net: Add trace events for all receive exit points

- On Nov 12, 2018, at 3:40 PM, rostedt rost...@goodmis.org wrote: > On Mon, 12 Nov 2018 15:20:55 -0500 (EST) > Mathieu Desnoyers wrote: > >> >> Hrm, looking at this again, I notice that there is a single DEFINE_EVENT >> using net_dev_template_simple. >> >> We could simply turn netif_receiv

Re: [PATCH v2] net: Add trace events for all receive exit points

On Mon, 12 Nov 2018 15:20:55 -0500 (EST) Mathieu Desnoyers wrote: > > Hrm, looking at this again, I notice that there is a single DEFINE_EVENT > using net_dev_template_simple. > > We could simply turn netif_receive_skb_list_exit into a TRACE_EVENT(), > remove the net_dev_template_simple, and re

Re: [PATCH v2] net: Add trace events for all receive exit points

- On Nov 12, 2018, at 3:20 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Nov 12, 2018, at 3:09 PM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: > >> - On Nov 12, 2018, at 2:44 PM, Geneviève Bastien gbast...@versatic.net >> wrote: >> >>> Trace events

Re: [PATCH v2] net: Add trace events for all receive exit points

On Mon, 12 Nov 2018 14:44:05 -0500 Geneviève Bastien wrote: > Trace events are already present for the receive entry points, to indicate > how the reception entered the stack. > > This patch adds the corresponding exit trace events that will bound the > reception such that all events occurring b

Re: [PATCH v2] net: Add trace events for all receive exit points

- On Nov 12, 2018, at 3:09 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Nov 12, 2018, at 2:44 PM, Geneviève Bastien gbast...@versatic.net > wrote: > >> Trace events are already present for the receive entry points, to indicate >> how the reception entered the stack.

Re: [PATCH v2] net: Add trace events for all receive exit points

- On Nov 12, 2018, at 2:44 PM, Geneviève Bastien gbast...@versatic.net wrote: > Trace events are already present for the receive entry points, to indicate > how the reception entered the stack. > > This patch adds the corresponding exit trace events that will bound the > reception such that