Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-18 Thread Eric Dumazet
On Mon, 2017-08-07 at 11:16 -0700, Rao Shoaib wrote: > Change from version 0: Rationale behind the change: > > The man page for tcp(7) states > > when used with the TCP keepalive (SO_KEEPALIVE) option, TCP_USER_TIMEOUT will > override keepalive to determine when to close a connection due to kee

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-10 Thread Jerry Chu
On Thu, Aug 10, 2017 at 2:05 PM, Rao Shoaib wrote: > > > On 08/09/2017 09:59 PM, Jerry Chu wrote: >> >> On Wed, Aug 9, 2017 at 8:32 PM, Jerry Chu wrote: >>> >>> On Wed, Aug 9, 2017 at 5:47 PM, Rao Shoaib wrote: On 08/09/2017 05:30 PM, David Miller wrote: > > From: Joe Smit

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-10 Thread Rao Shoaib
On 08/09/2017 09:59 PM, Jerry Chu wrote: On Wed, Aug 9, 2017 at 8:32 PM, Jerry Chu wrote: On Wed, Aug 9, 2017 at 5:47 PM, Rao Shoaib wrote: On 08/09/2017 05:30 PM, David Miller wrote: From: Joe Smith Date: Wed, 9 Aug 2017 17:20:32 -0700 Making Linux conform to standards and behavior th

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Jerry Chu
On Wed, Aug 9, 2017 at 8:32 PM, Jerry Chu wrote: > On Wed, Aug 9, 2017 at 5:47 PM, Rao Shoaib wrote: >> >> >> On 08/09/2017 05:30 PM, David Miller wrote: >>> >>> From: Joe Smith >>> Date: Wed, 9 Aug 2017 17:20:32 -0700 >>> Making Linux conform to standards and behavior that is logical seems

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Jerry Chu
On Wed, Aug 9, 2017 at 5:47 PM, Rao Shoaib wrote: > > > On 08/09/2017 05:30 PM, David Miller wrote: >> >> From: Joe Smith >> Date: Wed, 9 Aug 2017 17:20:32 -0700 >> >>> Making Linux conform to standards and behavior that is logical seems >>> like a good enough reason. >> >> That's an awesome atti

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread David Miller
From: Rao Shoaib Date: Wed, 9 Aug 2017 17:47:57 -0700 > > > On 08/09/2017 05:30 PM, David Miller wrote: >> From: Joe Smith >> Date: Wed, 9 Aug 2017 17:20:32 -0700 >> >>> Making Linux conform to standards and behavior that is logical seems >>> like a good enough reason. >> That's an awesome att

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Rao Shoaib
On 08/09/2017 05:30 PM, David Miller wrote: From: Joe Smith Date: Wed, 9 Aug 2017 17:20:32 -0700 Making Linux conform to standards and behavior that is logical seems like a good enough reason. That's an awesome attitude to have when we're implementing something new and don't have the facili

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Rao Shoaib
On 08/09/2017 05:20 PM, Joe Smith wrote: On Wed, Aug 9, 2017 at 4:52 PM, Jerry Chu wrote: [try to recover from long lost memory] On Tue, Aug 8, 2017 at 10:25 AM, Yuchung Cheng wrote: On Mon, Aug 7, 2017 at 11:16 AM, Rao Shoaib wrote: Change from version 0: Rationale behind the change: T

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread David Miller
From: Joe Smith Date: Wed, 9 Aug 2017 17:20:32 -0700 > Making Linux conform to standards and behavior that is logical seems > like a good enough reason. That's an awesome attitude to have when we're implementing something new and don't have the facility already. But when we have something alrea

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Joe Smith
On Wed, Aug 9, 2017 at 4:52 PM, Jerry Chu wrote: > [try to recover from long lost memory] > > On Tue, Aug 8, 2017 at 10:25 AM, Yuchung Cheng wrote: >> On Mon, Aug 7, 2017 at 11:16 AM, Rao Shoaib wrote: >>> Change from version 0: Rationale behind the change: >>> >>> The man page for tcp(7) states

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Jerry Chu
[try to recover from long lost memory] On Tue, Aug 8, 2017 at 10:25 AM, Yuchung Cheng wrote: > On Mon, Aug 7, 2017 at 11:16 AM, Rao Shoaib wrote: >> Change from version 0: Rationale behind the change: >> >> The man page for tcp(7) states >> >> when used with the TCP keepalive (SO_KEEPALIVE) opti

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-08 Thread Yuchung Cheng
On Mon, Aug 7, 2017 at 11:16 AM, Rao Shoaib wrote: > Change from version 0: Rationale behind the change: > > The man page for tcp(7) states > > when used with the TCP keepalive (SO_KEEPALIVE) option, TCP_USER_TIMEOUT will > override keepalive to determine when to close a connection due to keepal