Re: [PATCH v1] virtio_net: fix missing dma unmap for resize

2023-12-26 Thread Xuan Zhuo
On Tue, 26 Dec 2023 03:57:27 -0500, "Michael S. Tsirkin" wrote: > On Tue, Dec 26, 2023 at 01:57:09PM +0800, Xuan Zhuo wrote: > > On Tue, 12 Dec 2023 03:26:41 -0500, "Michael S. Tsirkin" > > wrote: > > > On Tue, Dec 12, 2023 at 04:11:41PM +0800, Xuan Zhuo wrote: > > > > For rq, we have three cas

Re: [PATCH v1] virtio_net: fix missing dma unmap for resize

2023-12-26 Thread Michael S. Tsirkin
On Tue, Dec 26, 2023 at 01:57:09PM +0800, Xuan Zhuo wrote: > On Tue, 12 Dec 2023 03:26:41 -0500, "Michael S. Tsirkin" > wrote: > > On Tue, Dec 12, 2023 at 04:11:41PM +0800, Xuan Zhuo wrote: > > > For rq, we have three cases getting buffers from virtio core: > > > > > > 1. virtqueue_get_buf{,_ctx}

Re: [PATCH v1] virtio_net: fix missing dma unmap for resize

2023-12-25 Thread Xuan Zhuo
On Tue, 12 Dec 2023 03:26:41 -0500, "Michael S. Tsirkin" wrote: > On Tue, Dec 12, 2023 at 04:11:41PM +0800, Xuan Zhuo wrote: > > For rq, we have three cases getting buffers from virtio core: > > > > 1. virtqueue_get_buf{,_ctx} > > 2. virtqueue_detach_unused_buf > > 3. callback for virtqueue_resiz

Re: [PATCH v1] virtio_net: fix missing dma unmap for resize

2023-12-12 Thread Michael S. Tsirkin
On Tue, Dec 12, 2023 at 04:11:41PM +0800, Xuan Zhuo wrote: > For rq, we have three cases getting buffers from virtio core: > > 1. virtqueue_get_buf{,_ctx} > 2. virtqueue_detach_unused_buf > 3. callback for virtqueue_resize > > But in commit 295525e29a5b("virtio_net: merge dma operations when > fi