RE: [PATCH rdma-next 11/19] RDMA/netlink: Convert LS to doit callback

2017-06-21 Thread Steve Wise
> > > - /* > > > - * For response or local service set_timeout request, > > > - * there is no need to use netlink_dump_start. > > > - */ > > > - if (!(nlh->nlmsg_flags & NLM_F_REQUEST) || > > > - (index == RDMA_NL_LS && op == RDMA_NL_LS_OP_SET_TIMEOUT)) { > > > - cb.skb = skb; > > >

Re: [PATCH rdma-next 11/19] RDMA/netlink: Convert LS to doit callback

2017-06-21 Thread Leon Romanovsky
On Wed, Jun 21, 2017 at 09:18:25AM -0500, Steve Wise wrote: > > From: Leon Romanovsky > > > > RDMA_NL_LS protocol is actually is not dump anything, > > nit: "is not" -> "does not" > > > but sets data and it should be handled by doit callback. > > > > This patch actually converts RDMA_NL_LS to doi

RE: [PATCH rdma-next 11/19] RDMA/netlink: Convert LS to doit callback

2017-06-21 Thread Steve Wise
> From: Leon Romanovsky > > RDMA_NL_LS protocol is actually is not dump anything, nit: "is not" -> "does not" > but sets data and it should be handled by doit callback. > > This patch actually converts RDMA_NL_LS to doit callback, while > preserving IWCM and RDMA_CM flows through netlink_dump