Re: [PATCH next] net: dsa: print error on invalid port index

2021-01-06 Thread Jakub Kicinski
On Wed, 6 Jan 2021 23:33:07 +0100 Andrew Lunn wrote: > On Wed, Jan 06, 2021 at 10:09:15AM +0100, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > Looking for an -EINVAL all over the dsa code could take hours for > > inexperienced DSA users. > > Following this argument, you should add dev_e

Re: [PATCH next] net: dsa: print error on invalid port index

2021-01-06 Thread Andrew Lunn
On Wed, Jan 06, 2021 at 10:09:15AM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > Looking for an -EINVAL all over the dsa code could take hours for > inexperienced DSA users. Following this argument, you should add dev_err() by every -EINVAL. > Signed-off-by: Rafał Miłecki Reviewed-by: