Re: [PATCH net v2 00/21] net: avoid to remove module when its debugfs is being used

2020-11-10 Thread Johannes Berg
On Sat, 2020-11-07 at 11:05 -0800, Jakub Kicinski wrote: > On Sat, 7 Nov 2020 17:21:31 + Taehee Yoo wrote: > > When debugfs file is opened, its module should not be removed until > > it's closed. > > Because debugfs internally uses the module's data. > > So, it could access freed memory. > >

Re: [PATCH net v2 00/21] net: avoid to remove module when its debugfs is being used

2020-11-07 Thread Taehee Yoo
On Sun, 8 Nov 2020 at 04:05, Jakub Kicinski wrote: > Hi Jakub, Thank you for the review! > On Sat, 7 Nov 2020 17:21:31 + Taehee Yoo wrote: > > When debugfs file is opened, its module should not be removed until > > it's closed. > > Because debugfs internally uses the module's data. > > So,

Re: [PATCH net v2 00/21] net: avoid to remove module when its debugfs is being used

2020-11-07 Thread Jakub Kicinski
On Sat, 7 Nov 2020 17:21:31 + Taehee Yoo wrote: > When debugfs file is opened, its module should not be removed until > it's closed. > Because debugfs internally uses the module's data. > So, it could access freed memory. > > In order to avoid panic, it just sets .owner to THIS_MODULE. > So t