Re: [PATCH net v2] ipv4: Fix use-after-free when flushing FIB tables

2017-12-20 Thread Ido Schimmel
On Wed, Dec 20, 2017 at 07:32:21AM -0800, Alexander Duyck wrote: > I think we might want even more description here. Specifically why > reversing the order allows local to be destroyed before main. I was > thinking something along the lines of: > > Destroy the tables in reverse order to guarantee

Re: [PATCH net v2] ipv4: Fix use-after-free when flushing FIB tables

2017-12-20 Thread Alexander Duyck
On Wed, Dec 20, 2017 at 12:51 AM, Ido Schimmel wrote: > Since commit 0ddcf43d5d4a ("ipv4: FIB Local/MAIN table collapse") the > local table uses the same trie allocated for the main table when custom > rules are not in use. > > When a net namespace is dismantled, the main table is flushed and free